Bug 1764625

Description of problem:
Satellite upgrade from 6.5.x to 6.6 causes strings being converted in booleans which in turn causes puppet failures. 

Version-Release number of selected component (if applicable):
Satellite 6.6

How reproducible:
100%

Steps to Reproduce:
1. Parameter String with value yes
2. Upgrade Satellite 6.5 to 6.6
3. Parameter becomes Boolean with value true

Actual results:
Parameter becomes Boolean with value true


https://github.com/theforeman/foreman/pull/5241/files#diff-b3682057e8f9486a9c336512544e9ee8R48
~~~
 def override_key_type_and_value(param)
    key_type_name = 'string'
    value = YAML.load param.value                    <<<<==============      IF THE VALUE IS "no" it returns "false"
    key_type_name = value.is_a?(Hash) ? 'yaml' : find_key_type(value)     <<==== find_key_type function call. 
rescue Psych::SyntaxError
~~~

Foreman-rake console output 
~~~
irb(main):031:0> Parameter.unscoped[3].value
=> "no"
irb(main):032:0> value = YAML.load Parameter.unscoped[3].value
=> false
irb(main):033:0> 
~~~

And then we have the function return the value as boolean

~~~
 def find_key_type(param_value)
    return 'boolean' if [true, false].include?(param_value)
    param_value.class.name.underscore.humanize.downcase
  end
end
~~~

Expected results:
Parameter stays String with value true

Additional info:
This change was introduced because of an RFE to have more types supported for parameters.
~~~
Currently "string" is the only parameter type supported in hostgroup parameters on foreman 1.3. Our customers desperately need to put Array and Boolean type of parameters (possibly other types as well) into the hostgroup for better puppet parameter management of they application clusters. Since multiple parameter types are supported in Smart Variables, why the hostgroup parameters (as well host parameter) have to stuck with just one type (string).
~~~

https://projects.theforeman.org/issues/4127
https://bugzilla.redhat.com/show_bug.cgi?id=1402136