Spec URL: https://raw.githubusercontent.com/dmsimard/python-django-health-check-distgit/master/python-django-health-check.spec SRPM URL: https://github.com/dmsimard/python-django-health-check-distgit/raw/master/python-django-health-check-3.11.0-1.fc30.src.rpm Description: A Django application that provides health check capabilities. Many of these checks involve connecting to back-end services and ensuring basic operations are successful. Fedora Account System Username: dmsimard
I will take this review.
No serious issues found, but I would like to offer a few comments. 1. Note that this line is not required: Requires: python3-django If you examine the Requires for the final binary package, you'll see: python3-django python3.8dist(django) >= 1.11 The first is due to the Requires line above. The second dependency is already generated from setup.py, and is more specific than your version. 2. Note the macro-in-comment warnings from rpmlint. You should use double percent signs, e.g., "%%check", so that rpm does not evaluate those macros. 3. The rpmlint warnings about objects.inv are, of course, wrong. You can make rpmlint stop warning with a file named python-django-health-check.rpmlintrc in the (not yet created) git repo containing something like the following: addFilter(r'W: wrong-file-end-of-line-encoding .*objects.inv') addFilter(r'W: file-not-utf8 .*objects.inv') Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package does not use a name that already exists. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-django-health-check-3.11.0-1.fc32.noarch.rpm python-django-health-check-doc-3.11.0-1.fc32.noarch.rpm python-django-health-check-3.11.0-1.fc32.src.rpm python-django-health-check-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-django-health-check-doc/html/objects.inv python-django-health-check-doc.noarch: W: file-not-utf8 /usr/share/doc/python-django-health-check-doc/html/objects.inv python-django-health-check.src:53: W: macro-in-comment %check python-django-health-check.src:55: W: macro-in-comment %{__python3} 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- python-django-health-check-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-django-health-check-doc/html/objects.inv python-django-health-check-doc.noarch: W: file-not-utf8 /usr/share/doc/python-django-health-check-doc/html/objects.inv 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://files.pythonhosted.org/packages/source/d/django-health-check/django-health-check-3.11.0.tar.gz : CHECKSUM(SHA256) this package : 805324b3a7275a087903928df4fc94759f131bc0ba7e5eb18806005c4a2a4f2f CHECKSUM(SHA256) upstream package : 805324b3a7275a087903928df4fc94759f131bc0ba7e5eb18806005c4a2a4f2f Requires -------- python3-django-health-check (rpmlib, GLIBC filtered): python(abi) python3-django python3.8dist(django) python-django-health-check-doc (rpmlib, GLIBC filtered): Provides -------- python3-django-health-check: python-django-health-check python3-django-health-check python3.8dist(django-health-check) python3dist(django-health-check) python-django-health-check-doc: python-django-health-check-doc Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -b 1764715 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: R, fonts, Ruby, Perl, Ocaml, SugarActivity, Haskell, PHP, Java, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
This package is APPROVED.
@Jerry, thank you very much for the review! I will address your comments before doing a build.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-django-health-check
FEDORA-2019-76486a1007 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-76486a1007
FEDORA-2019-d829790d26 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-d829790d26
python-django-health-check-3.11.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d829790d26
python-django-health-check-3.11.0-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-76486a1007
python-django-health-check-3.11.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
python-django-health-check-3.11.0-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.