Bug 1764753 - Review Request: rust-assert-json-diff - Easily compare two JSON values and get great output
Summary: Review Request: rust-assert-json-diff - Easily compare two JSON values and ge...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Igor Raits
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-10-23 17:27 UTC by Robert Fairley
Modified: 2019-11-08 10:43 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-11-08 10:43:56 UTC
Type: ---
Embargoed:
igor.raits: fedora-review+


Attachments (Terms of Use)
Metadata fix for assert-json-diff (350 bytes, patch)
2019-10-23 17:29 UTC, Robert Fairley
no flags Details | Diff

Description Robert Fairley 2019-10-23 17:27:46 UTC
Spec URL: https://rfairley.fedorapeople.org/package-review/rust-assert-json-diff/rust-assert-json-diff.spec
SRPM URL: https://rfairley.fedorapeople.org/package-review/rust-assert-json-diff/rust-assert-json-diff-1.0.0-1.fc32.src.rpm
Description: Easily compare two JSON values and get great output.
Fedora Account System Username: rfairley

The upstream notes an MIT license in the README.md [1], and the crate on crates.io has an MIT license. However, there is no LICENSE file currently in the upstream repository. A PR to add this is open: [2]

Needed to update `rust-mockito` from `0.17.1` to at least `0.20.0`, needed by `rust-zincati-0.0.6` [3]

Koji build: [4]

[1] https://github.com/davidpdrsn/assert-json-diff/blob/master/README.md
[2] https://github.com/davidpdrsn/assert-json-diff/pull/5
[3] https://bugzilla.redhat.com/show_bug.cgi?id=1759996#c3
[4] https://koji.fedoraproject.org/koji/taskinfo?taskID=38505942

Comment 1 Robert Fairley 2019-10-23 17:29:32 UTC
Created attachment 1628566 [details]
Metadata fix for assert-json-diff

Changes requirement on `version-sync` to `0.8` (currently in Fedora) from `0.5`.

Comment 2 Robert Fairley 2019-10-26 20:44:57 UTC
v1.0.1 was tagged, which includes a license file and a Cargo.toml using `version-sync-0.8` (https://github.com/davidpdrsn/assert-json-diff/releases/tag/v1.0.1). Will soon update the SRPM and specfile attached here.

Comment 4 Gwyn Ciesla 2019-11-07 16:37:33 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-assert-json-diff


Note You need to log in before you can comment on or make changes to this bug.