Bug 176523 - Review Request: python-json: A JSON reader and writer for Python
Summary: Review Request: python-json: A JSON reader and writer for Python
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: David Lawrence
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 176532
TreeView+ depends on / blocked
 
Reported: 2005-12-24 06:46 UTC by Ignacio Vazquez-Abrams
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-02-08 02:48:51 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Ignacio Vazquez-Abrams 2005-12-24 06:46:01 UTC
Spec Name or Url: http://fedora.ivazquez.net/files/extras/python-json.spec
SRPM Name or Url: http://fedora.ivazquez.net/files/extras/python-json-3_4-1.src.rpm
Description: json.py is an implementation of a JSON (http://json.org) reader and writer in Python.

Comment 1 Jeff Pitman 2005-12-30 04:35:26 UTC
I know upstream uses `_', but wouldn't be more aesthetically pleasing, for rpm,
to use `.'?

Comment 3 John Mahowald 2006-02-04 15:29:56 UTC
Minor:
Doesn't %ghost *.pyo like the python template does.

Good:

- rpmlint clean

- package meets naming guidelines
- package meets packaging guidelines
- license (LGPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

- unit tests pass

APPROVED

Comment 4 Ignacio Vazquez-Abrams 2006-02-08 02:48:51 UTC
Built for FC4 and devel.


Note You need to log in before you can comment on or make changes to this bug.