Red Hat Bugzilla – Bug 176574
OutOfMemory Exception during th refresh for Eclipse's Bugzilla
Last modified: 2007-11-30 17:11:19 EST
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US; rv:1.8) Gecko/20051202 Ubuntu/1.4.99+1.5rc3.dfsg-1ubuntu4 Epiphany/184.108.40.206 Firefox/1.5
Description of problem:
the plugin doesn't work with Eclipse's Bugzilla. I got a OutOfMemoryException
during the refresh. I created a patch against the CVS HEAD to fix various
problems I got.
Problems, I solved:
1. OOME during the parsing of Eclipse's Bugzilla query page.
2. NPE if I deselect all tree items.
3. Error in the creation of the status object for exceptions.
4. Read content type for attachments, before I got problems because the id
of the attachment wasn't read correct.
5. Make borders around lists.
6. UTF8(whatever)Exception because a java.io.Reader was used to read the binary
7. Use bugzillaAttachment.getDataAsString() only for text/* types.
8. Add Ubuntu's bugzilla
Version-Release number of selected component (if applicable):
Steps to Reproduce:
Created attachment 122587 [details]
Patch against org.eclipse.team.bugs (CVS HEAD)
Created attachment 122588 [details]
Patch against org.eclipse.team.bugzilla (CVS HEAD)
Created attachment 122845 [details]
Thanks for such an extensive patch to the plugin :). I've tested your patch and
it seems to work well. I've made some small syntactic changes, such as leaving
the explicit imports instead of .*, as well as making the instantiation of the
Status object in BugzillaPlugin a bit more readable.
If nothing else comes up I'll commit this.
Created attachment 122896 [details]
I am committing the patch, with some other minor changes, this is the final
Stephan, thanks again for the work.
The patch that you attached is a little messed up, Igor. Lots of the files are
completely changed according to the patch ... maybe you re-indented? It'd be
cool if the contextual differences were more apparent. Thanks.
Opening the patch up in vi shows that it's most likely that the files that were
changed without real changes had windows line endings. Since I already comitted
to CVS and I don't see converting win line endings to unix line endings as a big
transgression, I'll leave it in CVS as is, but I'll repost a patch without these
files for easier reading. :)
Created attachment 122953 [details]
Cleaned up patch
Here's a patch without the line-ending changes.