Bug 1766134 - Review Request: libacars - A library for decoding various ACARS message payloads
Summary: Review Request: libacars - A library for decoding various ACARS message payloads
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vitaly
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-10-28 11:51 UTC by Vasiliy Glazov
Modified: 2019-10-29 21:58 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-10-29 21:58:54 UTC
Type: Bug
Embargoed:
vitaly: fedora-review+

Attachments (Terms of Use)

Description Vasiliy Glazov 2019-10-28 11:51:33 UTC 
Spec URL: https://raw.githubusercontent.com/RussianFedora/libacars/master/libacars.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/5795/38615795/libacars-1.3.1-1.fc32.src.rpm

Description:
It is a library for decoding ACARS message contents.

Current stable version: 1.3.1

Supported message types
 FANS-1/A ADS-C (Automatic Dependent Surveillance - Contract)
 FANS-1/A CPDLC (Controller-Pilot Data Link Communications)
 MIAM (Media Independent Aircraft Messaging)
 Media Advisory (Status of data links: VDL2, HF, Satcom, VHF ACARS)
Comment 1 Vitaly 2019-10-29 13:28:16 UTC 
1. I suggest to switch from make to ninja.

2. Do not use %{_libdir}/%{name}.so.* to avoid accidental soversion bump.
Comment 2 Vasiliy Glazov 2019-10-29 13:36:54 UTC 
Spec URL: https://raw.githubusercontent.com/RussianFedora/libacars/master/libacars.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/4815/38644815/libacars-1.3.1-1.fc32.src.rpm

Use ninja for build and other spec improvements.
Comment 3 Vitaly 2019-10-29 13:47:53 UTC 
LGTM now. Package approved.
Comment 4 Gwyn Ciesla 2019-10-29 14:38:52 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/libacars
Note You need to log in before you can comment on or make changes to this bug.