Bug 1766137 - Review Request: libcorrect - C library for Convolutional codes and Reed-Solomon
Summary: Review Request: libcorrect - C library for Convolutional codes and Reed-Solomon
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vitaly
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-10-28 11:56 UTC by Vasiliy Glazov
Modified: 2019-10-29 21:58 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-10-29 21:58:34 UTC
Type: Bug
Embargoed:
vitaly: fedora-review+

Attachments (Terms of Use)

Description Vasiliy Glazov 2019-10-28 11:56:57 UTC 
Spec URL: https://raw.githubusercontent.com/RussianFedora/libcorrect/master/libcorrect.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/6000/38616000/libcorrect-0-1.20181010gitf5a28c7.fc32.src.rpm

Description:
It is a library for Forward Error Correction. By using libcorrect,
extra redundancy can be encoded into a packet of data and then be sent
across a lossy channel. When the packet is received, it can be decoded to
recover the original, pre-encoded data.
Comment 1 Vasiliy Glazov 2019-10-29 12:35:51 UTC 
Spec URL: https://raw.githubusercontent.com/RussianFedora/libcorrect/master/libcorrect.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3871/38643871/libcorrect-0-1.20181010gitf5a28c7.fc32.src.rpm

Use ninja for build.
Comment 2 Vitaly 2019-10-29 13:14:26 UTC 
> %{_libdir}/libcorrect.so.*

1. Not allowed anymore. You must use soversion to avoid accidental bump.

2. Missing %ninja_build -C %{_target_platform}.
Comment 3 Vitaly 2019-10-29 13:23:38 UTC 
There is nothing I can complain about. Package approved.
Comment 4 Gwyn Ciesla 2019-10-29 14:37:05 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/libcorrect
Note You need to log in before you can comment on or make changes to this bug.