Spec Name or Url: http://perso.wanadoo.fr/eric.tanguy/ushare.spec SRPM Name or Url: http://perso.wanadoo.fr/eric.tanguy/ushare-0.9.5-2.src.rpm Description: uShare is a UPnP (TM) A/V Media Server. It implements the server component that provides UPnP media devices with information on available multimedia files. uShare uses the built-in http server of libupnp to stream the files to clients.
$ rpmlint rpmbuild/SRPMS/ushare-0.9.5-2.src.rpm $ rpmlint rpmbuild/RPMS/i386/ushare-0.9.5-2.i386.rpm E: ushare explicit-lib-dependency libupnp E: ushare non-standard-uid /var/lib/ushare ushare E: ushare non-standard-gid /var/lib/ushare ushare E: ushare non-standard-dir-perm /var/lib/ushare 0770 W: ushare non-conffile-in-etc /etc/ushare.conf Some help with explicit-lib-dependency and non-conffile-in-etc, please.
(In reply to comment #1) > $ rpmlint rpmbuild/SRPMS/ushare-0.9.5-2.src.rpm > $ rpmlint rpmbuild/RPMS/i386/ushare-0.9.5-2.i386.rpm > E: ushare explicit-lib-dependency libupnp > E: ushare non-standard-uid /var/lib/ushare ushare > E: ushare non-standard-gid /var/lib/ushare ushare > E: ushare non-standard-dir-perm /var/lib/ushare 0770 > W: ushare non-conffile-in-etc /etc/ushare.conf > > Some help with explicit-lib-dependency and non-conffile-in-etc, please. You should be able to drop the "Requires: libupnp" because RPM's auto-dependency tracking should create an appropriate dependency for you. Use: %config(noreplace) %{_sysconfdir}/ushare.conf and that should get rid of the non-conffile-in-etc error.
Thanks New version : Spec Name or Url: http://perso.wanadoo.fr/eric.tanguy/ushare.spec SRPM Name or Url: http://perso.wanadoo.fr/eric.tanguy/ushare-0.9.5-3.src.rpm This package still need a formal review.
$ rpmlint rpmbuild/SRPMS/ushare-0.9.5-3.src.rpm $ rpmlint rpmbuild/RPMS/i386/ushare-0.9.5- ushare-0.9.5-1.i386.rpm ushare-0.9.5-2.i386.rpm ushare-0.9.5-3.i386.rpm [tanguy@bureau ~]$ rpmlint rpmbuild/RPMS/i386/ushare-0.9.5-3.i386.rpm E: ushare non-standard-uid /var/lib/ushare ushare E: ushare non-standard-gid /var/lib/ushare ushare E: ushare non-standard-dir-perm /var/lib/ushare 0770 This seems ok for me. May someone take a look at this package, please?
Good: - rpmlint checks return: E: ushare non-standard-uid /var/lib/ushare ushare E: ushare non-standard-gid /var/lib/ushare ushare E: ushare non-standard-dir-perm /var/lib/ushare 0770 Safe to ignore. - package meets naming guidelines - license (GPL) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file MAJOR BLOCKER: You should not use %{_datadir}/locale/* to grab the locale files. This causes you to own some of the locale directories. Instead, you should use the %find_lang macro like this: (at the end of %install): %find_lang %{name} Then, instead of %files, put: %files -f %{name}.lang Remove %{_datadir}/locale/*, the %{name}.lang will cover it. MINOR BLOCKER: Please uncomment the %doc line. It's valid. :) Show me a package with those blockers resolved, and I'll approve it.
Thanks New version : Spec Name or Url: http://perso.wanadoo.fr/eric.tanguy/ushare.spec SRPM Name or Url: http://perso.wanadoo.fr/eric.tanguy/ushare-0.9.5-4.src.rpm
Up ?
Please is this package needs a formal approve or is it tacitly approved ?
It's approved when (a) someone says it's approved *and* (b) changes the blocker bug from FE-REVIEW to FE-ACCEPT. So, no, it's not approved yet.
(In reply to comment #8) > Please is this package needs a formal approve or is it tacitly approved ? There ain't no such thing as a "tacitly approved" package in FE. You just need a bit more patience. In the meantime, you could review some packages, I notice spot has a few open review requests... :-)
New spec looks good, all blockers resolved, APPROVED.