Bug 1766276 - Catalog Name Not in Success Message When Adding Or Updating Catalog
Summary: Catalog Name Not in Success Message When Adding Or Updating Catalog
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.11.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: GA
: 5.12.0
Assignee: Richard Vsiansky
QA Contact: Niyaz Akhtar Ansari
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks: 1784187
TreeView+ depends on / blocked
 
Reported: 2019-10-28 17:22 UTC by juwatts
Modified: 2020-10-26 16:30 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1784187 (view as bug list)
Environment:
Last Closed: 2020-10-26 16:30:24 UTC
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description juwatts 2019-10-28 17:22:59 UTC
Description of problem:
When adding or updating a catalog, the assert message does not contain the catalog name

Version-Release number of selected component (if applicable):
5.11.0.27.20191001204742_d9cf38b


How reproducible:
100%

Steps to Reproduce:
1.Go to Services -> Catalogs -> Catalogs accordion
2.Add or Update a catalog 
3.View the success message

Actual results:
Catalog was saved

Expected results:
Catalog "{catalog_name}" was saved

Additional info:
Last working build: 5.10.12.1.20191022171907_f883bde

Comment 4 Richard Vsiansky 2019-10-30 14:39:07 UTC
https://github.com/ManageIQ/manageiq-ui-classic/pull/6352

Comment 5 CFME Bot 2019-11-05 13:47:05 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/d111a715cf132f0176adb70ccd43cbf46c2db626
commit d111a715cf132f0176adb70ccd43cbf46c2db626
Author:     Richard Vsiansky <r.vsia>
AuthorDate: Wed Oct 30 10:31:37 2019 -0400
Commit:     Richard Vsiansky <r.vsia>
CommitDate: Wed Oct 30 10:31:37 2019 -0400

    Show name in success catalog form messages

    https://bugzilla.redhat.com/show_bug.cgi?id=1766276

 app/controllers/catalog_controller.rb | 2 +-
 app/javascript/components/catalog-form/catalog-form.jsx | 4 +-
 app/javascript/spec/catalog-form/catalog-form.spec.js | 6 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

Comment 6 CFME Bot 2019-11-05 13:49:06 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/d111a715cf132f0176adb70ccd43cbf46c2db626
commit d111a715cf132f0176adb70ccd43cbf46c2db626
Author:     Richard Vsiansky <r.vsia>
AuthorDate: Wed Oct 30 10:31:37 2019 -0400
Commit:     Richard Vsiansky <r.vsia>
CommitDate: Wed Oct 30 10:31:37 2019 -0400

    Show name in success catalog form messages

    https://bugzilla.redhat.com/show_bug.cgi?id=1766276

 app/controllers/catalog_controller.rb | 2 +-
 app/javascript/components/catalog-form/catalog-form.jsx | 4 +-
 app/javascript/spec/catalog-form/catalog-form.spec.js | 6 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

Comment 8 Richard Vsiansky 2019-11-11 14:25:15 UTC
Hi,

You are right. https://github.com/ManageIQ/manageiq-ui-classic/pull/5139 This is a PR which converted the catalog form into a react form (and removed the name from the message.)

Richard


Note You need to log in before you can comment on or make changes to this bug.