Bug 1766626 - BR on jgit is conditionalised
Summary: BR on jgit is conditionalised
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: git
Version: 31
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Todd Zullinger
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1778390
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-10-29 14:17 UTC by Mat Booth
Modified: 2019-12-18 01:52 UTC (History)
8 users (show)

Fixed In Version: git-2.24.1-1.fc31
Clone Of:
Environment:
Last Closed: 2019-12-18 01:52:38 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Mat Booth 2019-10-29 14:17:24 UTC
I notice you still have the conditional here:

https://src.fedoraproject.org/rpms/git/blob/master/f/git.spec#_211

JGit should be available for all platforms since I split out the command line utility part from the Eclipse plug-in part.

Comment 1 Todd Zullinger 2019-10-31 03:36:42 UTC
Hi Mat,

Thanks for noticing and bringing this up!

Looking at the git history, jgit was disabled on s390x not because it wasn't available, but because it was unreliable¹.  It caused the test suite to hang in t5512-ls-remote.sh on a number of different occasions.

I'll try to run some scratch builds and see if I can still reproduce the problem.  If so, maybe we can work out what it is and fix it, whether that's in the git tests, jgit, or something else on s390x.

I know now that the errors Kevin found in the test output were red-herrings (the build-classpath messages, which I believe you fixed up in the jgit wrapper).  So I don't really have much of a clue as to what might be wrong.  But perhaps with more experience with the git test suite under my belt I'll be better able to make some progress on it this time.

It certainly would be good to get some compatibility testing between git and jgit on a big-endian architecture.  We've caught git issues twice now in the past few releases that only affected such architectures.

¹ https://src.fedoraproject.org/rpms/git/c/fd92980 ("Disable jgit tests on s390x, they're unreliable", 2018-05-30)

Comment 2 Todd Zullinger 2019-10-31 03:40:24 UTC
Oh, and I guess maybe the more important part is that I can re-enable the jgit BR on fedora > 30.

Comment 3 Todd Zullinger 2019-10-31 03:56:49 UTC
Alas, it appears to not be possible to install jgit on rawhide right now (at least in koji).  All of the arches failed in a scratch build with this error in the root.log:

  DEBUG util.py:593:  Error: 
  DEBUG util.py:593:   Problem: conflicting requests
  DEBUG util.py:593:    - nothing provides mvn(org.apache.sshd:sshd-sftp) needed by jgit-5.3.0-5.fc31.noarch
  DEBUG util.py:593:    - nothing provides mvn(org.apache.sshd:sshd-core) needed by jgit-5.3.0-5.fc31.noarch
  DEBUG util.py:593:    - nothing provides mvn(org.apache.sshd:sshd-sftp) needed by jgit-5.4.0-5.fc31.noarch
  DEBUG util.py:593:    - nothing provides mvn(org.apache.sshd:sshd-osgi) needed by jgit-5.4.0-5.fc31.noarch
  DEBUG util.py:593:    - nothing provides apache-sshd >= 1:2.2.0 needed by jgit-5.4.0-5.fc31.noarch
  DEBUG util.py:595:  (try to add '--skip-broken' to skip uninstallable packages)

Am I missing something silly or is this just something we'll have to wait to get sorted out in the buildsystem?

Here's the scratch build:

  https://koji.fedoraproject.org/koji/taskinfo?taskID=38675567

Comment 4 Mat Booth 2019-11-30 15:58:47 UTC
Sigh, looks like one of jgit's deps got retired. I filed a re-review to restore it.

The review bug is here: https://bugzilla.redhat.com/show_bug.cgi?id=1778390

Comment 5 Mat Booth 2019-12-02 11:05:40 UTC
jgit should be installable again after the next rawhide compose -- please let me know if you have further problems with it

Comment 6 Fedora Update System 2019-12-10 19:54:34 UTC
FEDORA-2019-c841bcc3b9 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-c841bcc3b9

Comment 7 Fedora Update System 2019-12-11 01:41:57 UTC
git-2.24.1-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c841bcc3b9

Comment 8 Fedora Update System 2019-12-18 01:52:38 UTC
git-2.24.1-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.