Bug 1767062 - Review Request: R-Rhtslib - HTSlib high-throughput sequencing library as an R package
Summary: Review Request: R-Rhtslib - HTSlib high-throughput sequencing library as an R...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Stephen Gallagher
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-10-30 15:36 UTC by Tom "spot" Callaway
Modified: 2019-10-31 15:51 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-10-31 15:51:44 UTC
Type: ---
Embargoed:
sgallagh: fedora-review+


Attachments (Terms of Use)

Description Tom "spot" Callaway 2019-10-30 15:36:10 UTC
Spec URL: https://spot.fedorapeople.org/R-Rhtslib.spec
SRPM URL: https://spot.fedorapeople.org/R-Rhtslib-1.16.3-1.fc31.src.rpm
Description: 
This package provides version 1.7 of the 'HTSlib' C library for
high-throughput sequence analysis. The package is primarily useful to
developers of other R packages who wish to make use of HTSlib. Motivation and
instructions for use of this package are in the vignette,
vignette(package="Rhtslib", "Rhtslib").
Fedora Account System Username: spot
Rawhide Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=38664468

A few notes: While there is already an htslib package in Fedora, it is very different, as this R module has stuck to an older code branch (and may have made local changes). This specific module is needed for R-Rsamtools to update to the latest version, which also frees up the Fedora samtools package to update to the current version.

Basically, I need R-Rhtslib to keep R-Rsamtools alive.

Also, there is one zero-length test file in R-Rhtslib. This is intentionally empty. Please ignore the rpmlint error there.

Comment 1 Stephen Gallagher 2019-10-30 20:33:25 UTC
Fedora-review is crashing for me when I try to review this, so I've gone through it manually.

Everything looks in order to me.

Comment 2 Miro Hrončok 2019-10-30 22:37:56 UTC
Could you please report the crash to https://pagure.io/FedoraReview/issues ?

Or is it https://pagure.io/FedoraReview/issue/366 ?

Comment 3 Stephen Gallagher 2019-10-31 12:29:26 UTC
(In reply to Miro Hrončok from comment #2)
> Could you please report the crash to https://pagure.io/FedoraReview/issues ?
> 
> Or is it https://pagure.io/FedoraReview/issue/366 ?

It's issue 366 exactly.

Comment 4 Miro Hrončok 2019-10-31 12:31:51 UTC
Thanks!

Comment 5 Gwyn Ciesla 2019-10-31 14:08:41 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/R-Rhtslib

Comment 6 Tom "spot" Callaway 2019-10-31 15:51:28 UTC
R-Rhtslib-1.16.3-1.fc32 built in rawhide. 

Thanks for the quick review.


Note You need to log in before you can comment on or make changes to this bug.