Bug 1767359
| Summary: | [sos] Fix OVN plugins and add support for containerized environments [rhel-8.1.0.z] | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Oneata Mircea Teodor <toneata> |
| Component: | sos | Assignee: | Pavel Moravec <pmoravec> |
| Status: | CLOSED ERRATA | QA Contact: | Miroslav Hradílek <mhradile> |
| Severity: | urgent | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 8.0 | CC: | agk, bmr, dalvarez, fkrska, gavin, jhunsaker, mhradile, plambri, pmoravec, sbradley |
| Target Milestone: | rc | Keywords: | OtherQA, ZStream |
| Target Release: | 8.0 | Flags: | pm-rhel:
mirror+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | sos-3.7-8.el8_1 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1744553 | Environment: | |
| Last Closed: | 2019-12-17 10:50:02 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1732525, 1744553 | ||
| Bug Blocks: | |||
|
Comment 2
Pavel Moravec
2019-11-07 13:03:29 UTC
Hello, could you please verify this BZ against below build for 8.1.z? A yum repository for the build of sos-3.7-7.el8_1 (task 24542408) is available at: http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.7/7.el8_1/ You can install the rpms locally by putting this .repo file in your /etc/yum.repos.d/ directory: http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.7/7.el8_1/sos-3.7-7.el8_1.repo RPMs and build logs can be found in the following locations: http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.7/7.el8_1/noarch/ The full list of available rpms is: http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.7/7.el8_1/noarch/sos-3.7-7.el8_1.src.rpm http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.7/7.el8_1/noarch/sos-audit-3.7-7.el8_1.noarch.rpm http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.7/7.el8_1/noarch/sos-3.7-7.el8_1.noarch.rpm Build output will be available for the next 21 days. Sorry forgot to update this on the RHEL8 BZs. I tried it on an OSP15 setup and it worked as expected Sorry again, it only works with this patch. It was refused to be merged in 'sos' upstream because it is a workaround to a podman issue. I reported the podman issue here [1] so either we merge [0] or we wait until [1] gets fixed. Without [0], 'sosreport' command will hang forever. I installed this package and applied [0], then all works: [root@controller-0 ovn_central]# rpm -qa| grep sos sos-3.7-7.el8_1.noarch [root@controller-0 ovn_central]# wc -l podman_exec_ovn-dbs-bundle-podman-0_ovn-sbctl_list_Chassis 35 podman_exec_ovn-dbs-bundle-podman-0_ovn-sbctl_list_Chassis [root@controller-0 ovn_host]# wc -l ovs-vsctl_list_Open_vSwitch 17 ovs-vsctl_list_Open_vSwitch Please, Pavel can you reconsider merging [0]? [0] https://github.com/danalsan/sos/commit/61262f347a685489336646d23f5aeb73a9c55aa3 [1] https://bugzilla.redhat.com/show_bug.cgi?id=1732525 (In reply to Daniel Alvarez Sanchez from comment #6) > Sorry again, it only works with this patch. It was refused to be merged in > 'sos' upstream because it is a workaround to a podman issue. > I reported the podman issue here [1] so either we merge [0] or we wait until > [1] gets fixed. > > Without [0], 'sosreport' command will hang forever. > > > I installed this package and applied [0], then all works: > > [root@controller-0 ovn_central]# rpm -qa| grep sos > sos-3.7-7.el8_1.noarch > > [root@controller-0 ovn_central]# wc -l > podman_exec_ovn-dbs-bundle-podman-0_ovn-sbctl_list_Chassis > 35 podman_exec_ovn-dbs-bundle-podman-0_ovn-sbctl_list_Chassis > > [root@controller-0 ovn_host]# wc -l ovs-vsctl_list_Open_vSwitch > 17 ovs-vsctl_list_Open_vSwitch > > Please, Pavel can you reconsider merging [0]? > > [0] > https://github.com/danalsan/sos/commit/ > 61262f347a685489336646d23f5aeb73a9c55aa3 > [1] https://bugzilla.redhat.com/show_bug.cgi?id=1732525 Hi Bryn, what is your opinion to add https://github.com/danalsan/sos/commit/61262f347a685489336646d23f5aeb73a9c55aa3 that you dropped from the PR in https://github.com/sosreport/sos/pull/1767#issuecomment-530431096 ? I dont like much workarounding bugs in other components in sosreport in the way it can possibly affect collection of _any_ command. Esp. when the workaround sounds to live forever (the podman bug is untouched). Rather as a workaround in sos, I am OK with either dropping / not collecting the problematic command, or calling it in some other way ("/bin/bash cmd" or "time 10s cmd" or similar, or adding some TERM variable? if either of that works). (In reply to Daniel Alvarez Sanchez from comment #6) > Without [0], 'sosreport' command will hang forever. Just to confirm if I got this right: the tested sos-3.7-7.el8_1 (without [0]) does hang forever on the "podman ps" command? If so, and since I doubt we will risk the adding pipe/stdin to each and every command in a _z_ stream, we must either: - revert the change completely - or at least remove the hung command "podman ps" from being collected (i.e. remove https://github.com/sosreport/sos/blob/master/sos/plugins/podman.py#L52-L53) - or come up with a workaround like "/bin/bash podman ps" or whatever that will work Daniel, could you please check if some such workaround is possible, or agree with either option? (default is dropping the cmd) I sent a new PR to overcome the pipe issue discussed here: https://github.com/sosreport/sos/pull/1865 Daniel, could you pls. review if https://github.com/sosreport/sos/pull/1875 is sufficient workaround in sos? (In reply to Pavel Moravec from comment #23) > Daniel, > could you pls. review if https://github.com/sosreport/sos/pull/1875 is > sufficient workaround in sos? .. and verify the current plugin works fine in downstream package? Thanks in advance. A yum repository for the build of sos-3.7-8.el8_1 (task 25182251) is available at: http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.7/8.el8_1/ You can install the rpms locally by putting this .repo file in your /etc/yum.repos.d/ directory: http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.7/8.el8_1/sos-3.7-8.el8_1.repo RPMs and build logs can be found in the following locations: http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.7/8.el8_1/noarch/ The full list of available rpms is: http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.7/8.el8_1/noarch/sos-3.7-8.el8_1.src.rpm http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.7/8.el8_1/noarch/sos-3.7-8.el8_1.noarch.rpm http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.7/8.el8_1/noarch/sos-audit-3.7-8.el8_1.noarch.rpm Build output will be available for the next 21 days. removing obsolete needinfo Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:4278 |