Bug 1767543 - Port IMS Workflow - Collapse Snapshots
Summary: Port IMS Workflow - Collapse Snapshots
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: V2V
Version: 5.11.0
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: GA
: 5.11.4
Assignee: Fabien Dupont
QA Contact: Md Nadeem
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On: 1740881
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-10-31 16:28 UTC by Satoe Imaishi
Modified: 2020-03-17 13:24 UTC (History)
7 users (show)

Fixed In Version: 5.11.4.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1740881
Environment:
Last Closed: 2020-03-17 13:24:01 UTC
Category: ---
Cloudforms Team: V2V
Target Upstream Version:
Embargoed:
pm-rhel: cfme-5.11.z+


Attachments (Terms of Use)

Comment 2 CFME Bot 2019-10-31 21:35:54 UTC
New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/c24dc236792de31fa9e4f03118b744cd1cba03f9
commit c24dc236792de31fa9e4f03118b744cd1cba03f9
Author:     Adam Grare <agrare>
AuthorDate: Mon Aug 26 18:53:16 2019 -0400
Commit:     Adam Grare <agrare>
CommitDate: Mon Aug 26 18:53:16 2019 -0400

    Merge pull request #19177 from fdupont-redhat/v2v_state_machine_collapse_snapshots

    [V2V] Add collapsing_snapshots state to InfraConversionJob

    (cherry picked from commit fb42c499d480b3ebbe77b36c87af195da70208a6)

    https://bugzilla.redhat.com/show_bug.cgi?id=1767543

 app/models/infra_conversion_job.rb | 72 +-
 spec/models/infra_conversion_job_spec.rb | 149 +-
 2 files changed, 187 insertions(+), 34 deletions(-)

Comment 3 CFME Bot 2019-10-31 21:51:37 UTC
New commit detected on ManageIQ/manageiq-content/ivanchuk:

https://github.com/ManageIQ/manageiq-content/commit/f8d1c45aff1132f2b10daa7b84c9afe802001c22
commit f8d1c45aff1132f2b10daa7b84c9afe802001c22
Author:     Greg McCullough <gmccullo>
AuthorDate: Thu Aug 29 07:02:14 2019 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Thu Aug 29 07:02:14 2019 -0400

    Merge pull request #566 from fdupont-redhat/v2v_state_machine_remove_collapse_snapshots

    [V2V] Remove CollapseSnapshots state and methods

    (cherry picked from commit 2e96f80c70aecb5f9f85d39a04f74ff59acd4860)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767543

 content/automate/ManageIQ/Transformation/Infrastructure/VM/Common.class/__methods__/collapsesnapshots.rb | 30 -
 content/automate/ManageIQ/Transformation/Infrastructure/VM/Common.class/__methods__/collapsesnapshots.yaml | 15 -
 content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/pretransform.yaml | 8 -
 3 files changed, 53 deletions(-)

Comment 4 Shveta 2019-11-21 22:05:49 UTC
Hi , 
Please provide the verification steps for this.
Thanks, 
Shveta

Comment 5 Fabien Dupont 2019-11-22 16:15:48 UTC
It's also a non regression. So, you should see no difference.

Comment 6 CFME Bot 2019-12-03 16:23:44 UTC
New commit detected on ManageIQ/manageiq-content/ivanchuk:

https://github.com/ManageIQ/manageiq-content/commit/ef852cadf851d2835424c46ccf8db2fef62e2074
commit ef852cadf851d2835424c46ccf8db2fef62e2074
Author:     Satoe Imaishi <simaishi>
AuthorDate: Tue Dec  3 11:13:32 2019 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Tue Dec  3 11:13:32 2019 -0500

    Revert "Merge pull request #566 from fdupont-redhat/v2v_state_machine_remove_collapse_snapshots"

    This reverts commit f8d1c45aff1132f2b10daa7b84c9afe802001c22.

    https://bugzilla.redhat.com/show_bug.cgi?id=1767543

 content/automate/ManageIQ/Transformation/Infrastructure/VM/Common.class/__methods__/collapsesnapshots.rb | 30 +
 content/automate/ManageIQ/Transformation/Infrastructure/VM/Common.class/__methods__/collapsesnapshots.yaml | 15 +
 content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/pretransform.yaml | 8 +
 3 files changed, 53 insertions(+)

Comment 7 CFME Bot 2019-12-03 18:11:08 UTC
New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/2a69c48b42e2ce910c64a687c404de4d1b1edf7d
commit 2a69c48b42e2ce910c64a687c404de4d1b1edf7d
Author:     Satoe Imaishi <simaishi>
AuthorDate: Tue Dec  3 12:46:41 2019 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Tue Dec  3 12:46:41 2019 -0500

    Revert "Merge pull request #19177 from fdupont-redhat/v2v_state_machine_collapse_snapshots"

    This reverts commit c24dc236792de31fa9e4f03118b744cd1cba03f9.

    https://bugzilla.redhat.com/show_bug.cgi?id=1767543

 app/models/infra_conversion_job.rb | 72 +-
 spec/models/infra_conversion_job_spec.rb | 149 +-
 2 files changed, 34 insertions(+), 187 deletions(-)

Comment 8 CFME Bot 2020-02-21 19:35:26 UTC
New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/6a139ae94c675589d88793b6351a6cc3381c8151
commit 6a139ae94c675589d88793b6351a6cc3381c8151
Author:     Adam Grare <agrare>
AuthorDate: Mon Aug 26 22:53:16 2019 +0000
Commit:     Adam Grare <agrare>
CommitDate: Mon Aug 26 22:53:16 2019 +0000

    Merge pull request #19177 from fdupont-redhat/v2v_state_machine_collapse_snapshots

    [V2V] Add collapsing_snapshots state to InfraConversionJob

    (cherry picked from commit fb42c499d480b3ebbe77b36c87af195da70208a6)

    https://bugzilla.redhat.com/show_bug.cgi?id=1767543

 app/models/infra_conversion_job.rb | 72 +-
 spec/models/infra_conversion_job_spec.rb | 149 +-
 2 files changed, 187 insertions(+), 34 deletions(-)

Comment 9 CFME Bot 2020-02-21 19:55:54 UTC
New commit detected on ManageIQ/manageiq-content/ivanchuk:

https://github.com/ManageIQ/manageiq-content/commit/702e072fccbbb44ae6d6c0de1254bf62a6f3bc4a
commit 702e072fccbbb44ae6d6c0de1254bf62a6f3bc4a
Author:     Greg McCullough <gmccullo>
AuthorDate: Thu Aug 29 11:02:14 2019 +0000
Commit:     Greg McCullough <gmccullo>
CommitDate: Thu Aug 29 11:02:14 2019 +0000

    Merge pull request #566 from fdupont-redhat/v2v_state_machine_remove_collapse_snapshots

    [V2V] Remove CollapseSnapshots state and methods

    (cherry picked from commit 2e96f80c70aecb5f9f85d39a04f74ff59acd4860)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767543

 content/automate/ManageIQ/Transformation/Infrastructure/VM/Common.class/__methods__/collapsesnapshots.rb | 30 -
 content/automate/ManageIQ/Transformation/Infrastructure/VM/Common.class/__methods__/collapsesnapshots.yaml | 15 -
 content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/pretransform.yaml | 8 -
 3 files changed, 53 deletions(-)

Comment 10 Md Nadeem 2020-03-05 06:41:08 UTC
Verified in cfme version 5.11.4.1 with Downstream UCI image: v2v-conversion-host-appliance-5.11.4.1-1_scratch.x86_64.qcow2.
The migration does not destroy the attached snapshot details at src provider in case required a roll back, however you won't get the snapshot details for a successfull migrated VM at destination side. This is the exepected behavior as confirmed by @fabien


Note You need to log in before you can comment on or make changes to this bug.