Bug 1767787 - Collect vNIC profiles from RHV 4.x as part of EMS Refresh
Summary: Collect vNIC profiles from RHV 4.x as part of EMS Refresh
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: GA
: 5.11.2
Assignee: Boriso
QA Contact: Jaroslav Henner
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On: 1576509
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-11-01 12:30 UTC by Satoe Imaishi
Modified: 2022-03-13 17:06 UTC (History)
17 users (show)

Fixed In Version: 5.11.2.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1576509
Environment:
Last Closed: 2020-02-12 05:02:24 UTC
Category: ---
Cloudforms Team: RHEVM
Target Upstream Version:
Embargoed:
pm-rhel: cfme-5.11.z+
simaishi: mirror+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github ManageIQ manageiq-content pull 582 0 'None' closed Add handling vnic events for rhev 2020-11-03 15:22:25 UTC
Github ManageIQ manageiq-providers-ovirt pull 401 0 'None' closed Remodel networking for RHV 2020-11-03 15:22:42 UTC
Github ManageIQ manageiq pull 19262 0 'None' closed Add distributed_virtual_lans for infra_manager 2020-11-03 15:22:25 UTC
Github ManageIQ manageiq pull 19306 0 'None' closed Add distributed_virtual_lans to persister 2020-11-03 15:22:25 UTC
Red Hat Product Errata RHBA-2020:0452 0 None None None 2020-02-12 05:02:34 UTC

Comment 2 CFME Bot 2019-11-01 19:32:43 UTC
New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/da5492fe8b9a85c55c6e21ab109f91d87a12152b
commit da5492fe8b9a85c55c6e21ab109f91d87a12152b
Author:     Adam Grare <agrare>
AuthorDate: Thu Sep  5 09:09:07 2019 -0400
Commit:     Adam Grare <agrare>
CommitDate: Thu Sep  5 09:09:07 2019 -0400

    Merge pull request #19262 from borod108/bugs/add_dvlans_1576509

    Add distributed_virtual_lans for infra_manager

    (cherry picked from commit 4afdee6cd6b899cb091876ef70e2d6df45ff1c9c)

    https://bugzilla.redhat.com/show_bug.cgi?id=1767787

 app/models/manageiq/providers/infra_manager.rb | 1 +
 1 file changed, 1 insertion(+)


https://github.com/ManageIQ/manageiq/commit/99ef30aa6324b0affdba2b330c23d6c8c1e8c748
commit 99ef30aa6324b0affdba2b330c23d6c8c1e8c748
Author:     Adam Grare <agrare>
AuthorDate: Tue Sep 17 16:59:52 2019 -0400
Commit:     Adam Grare <agrare>
CommitDate: Tue Sep 17 16:59:52 2019 -0400

    Merge pull request #19306 from borod108/add_persister_vlans

    Add distributed_virtual_lans to persister

    (cherry picked from commit 387fc32257bbffab5a1dfc0d48a54c5f2bc3b81a)

    https://bugzilla.redhat.com/show_bug.cgi?id=1767787

 app/models/manageiq/providers/inventory/persister/builder/infra_manager.rb | 7 +
 1 file changed, 7 insertions(+)

Comment 3 CFME Bot 2019-11-01 19:42:49 UTC
New commit detected on ManageIQ/manageiq-content/ivanchuk:

https://github.com/ManageIQ/manageiq-content/commit/e3366f12f02de4ecc85bbac3a1e123c2b32b0f06
commit e3366f12f02de4ecc85bbac3a1e123c2b32b0f06
Author:     Greg McCullough <gmccullo>
AuthorDate: Wed Sep 18 08:12:22 2019 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Wed Sep 18 08:12:22 2019 -0400

    Merge pull request #582 from borod108/bug/network_remod

    Add handling vnic events for rhev

    (cherry picked from commit e1662534fad5168be34f4128010dd9dd49220c23)

    https://bugzilla.redhat.com/show_bug.cgi?id=1767787

 content/automate/ManageIQ/System/Event/EmsEvent/RHEVM.class/add_vnic_profile.yaml | 12 +
 content/automate/ManageIQ/System/Event/EmsEvent/RHEVM.class/network_add_network.yaml | 12 +
 content/automate/ManageIQ/System/Event/EmsEvent/RHEVM.class/network_update_network.yaml | 12 +
 content/automate/ManageIQ/System/Event/EmsEvent/RHEVM.class/remove_vnic_profile.yaml | 12 +
 content/automate/ManageIQ/System/Event/EmsEvent/RHEVM.class/update_vnic_profile.yaml | 12 +
 5 files changed, 60 insertions(+)

Comment 4 CFME Bot 2019-11-01 19:44:14 UTC
New commit detected on ManageIQ/manageiq-providers-ovirt/ivanchuk:

https://github.com/ManageIQ/manageiq-providers-ovirt/commit/681308d08ee9280b1998f8a3f4aa82eb457c6f47
commit 681308d08ee9280b1998f8a3f4aa82eb457c6f47
Author:     Adam Grare <agrare>
AuthorDate: Wed Sep 18 08:58:06 2019 -0400
Commit:     Adam Grare <agrare>
CommitDate: Wed Sep 18 08:58:06 2019 -0400

    Merge pull request #401 from borod108/rfe/remod_network

    Remodel networking for RHV

    (cherry picked from commit 4137789641ca0b1784b6f56c02d5e550bcdd0a76)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767787

 app/models/manageiq/providers/redhat/infra_manager.rb | 1 +
 app/models/manageiq/providers/redhat/infra_manager/distributed_virtual_switch.rb | 2 +
 app/models/manageiq/providers/redhat/infra_manager/inventory/strategies/v4.rb | 3 +-
 app/models/manageiq/providers/redhat/infra_manager/ovirt_services/builder.rb | 2 +-
 app/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v4.rb | 33 +-
 app/models/manageiq/providers/redhat/inventory/collector.rb | 8 +-
 app/models/manageiq/providers/redhat/inventory/collector/infra_manager.rb | 2 +-
 app/models/manageiq/providers/redhat/inventory/collector/target_collection.rb | 17 +
 app/models/manageiq/providers/redhat/inventory/parser/infra_manager.rb | 82 +-
 app/models/manageiq/providers/redhat/inventory/persister/infra_manager.rb | 6 +-
 spec/factories/switch.rb | 7 +
 spec/models/manageiq/providers/redhat/infra_manager/event_parser_spec.rb | 150 -
 spec/models/manageiq/providers/redhat/infra_manager/provision/configuration/network_spec.rb | 102 +-
 spec/models/manageiq/providers/redhat/infra_manager/provision/state_machine_spec.rb | 27 -
 spec/models/manageiq/providers/redhat/infra_manager/provision_spec.rb | 36 +-
 spec/models/manageiq/providers/redhat/infra_manager/provision_via_iso/state_machine_spec.rb | 13 -
 spec/models/manageiq/providers/redhat/infra_manager/provision_workflow_spec.rb | 45 +-
 spec/models/manageiq/providers/redhat/infra_manager/refresh/refresh_recording_modifier_spec.rb | 2 +
 spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_4_async_graph_spec.rb | 367 +-
 spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_4_async_spec.rb | 789 -
 spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_4_custom_attributes_spec.rb | 10 +-
 spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_graph_target_host_spec.rb | 9 +-
 spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_graph_target_template_spec.rb | 4 +-
 spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_graph_target_vm_spec.rb | 17 +-
 spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_huge_async_spec.rb | 3 +
 spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_lans_spec.rb | 26 +
 spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_network_spec.rb | 804 +
 spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_target_host_4_spec.rb | 10 +-
 spec/models/manageiq/providers/redhat/infra_manager/vm_spec.rb | 41 -
 spec/vcr_cassettes/manageiq/providers/redhat/infra_manager/refresh/ovirt_lans_refresh_recording.yml | 10524 +
 spec/vcr_cassettes/manageiq/providers/redhat/infra_manager/refresh/ovirt_sdk_refresh_graph_target_host.yml | 7016 +-
 spec/vcr_cassettes/manageiq/providers/redhat/infra_manager/refresh/ovirt_sdk_refresh_graph_target_template.yml | 5130 +-
 spec/vcr_cassettes/manageiq/providers/redhat/infra_manager/refresh/ovirt_sdk_refresh_graph_target_template_with_host.yml | 5121 +-
 spec/vcr_cassettes/manageiq/providers/redhat/infra_manager/refresh/ovirt_sdk_refresh_graph_target_vm_after_full.yml | 5584 +
 spec/vcr_cassettes/manageiq/providers/redhat/infra_manager/refresh/ovirt_sdk_refresh_graph_target_vm_deleted_snapshot.yml | 5690 +-
 spec/vcr_cassettes/manageiq/providers/redhat/infra_manager/refresh/ovirt_sdk_refresh_graph_target_vm_removal.yml | 5183 +-
 spec/vcr_cassettes/manageiq/providers/redhat/infra_manager/refresh/ovirt_sdk_refresh_graph_target_vm_with_host.yml | 5036 +-
 spec/vcr_cassettes/manageiq/providers/redhat/infra_manager/refresh/ovirt_sdk_refresh_recording.yml | 9130 +-
 spec/vcr_cassettes/manageiq/providers/redhat/infra_manager/refresh/ovirt_sdk_refresh_recording_custom_attrs.yml | 19218 +-
 spec/vcr_cassettes/manageiq/providers/redhat/infra_manager/refresh/refresher_network_recording.yml | 7318 +
 spec/vcr_cassettes/manageiq/providers/redhat/infra_manager/refresh/refresher_target_host.yml | 122 +-
 41 files changed, 64580 insertions(+), 23110 deletions(-)

Comment 5 Angelina Vasileva 2019-11-15 09:04:28 UTC
Tested on 5.11.1.0.20191105221526_f1764d4 with RHV 5.11.1.0.20191105221526_f1764d4.

I have 2 vNIC profiles in the RHV: ovirtmgmt and test_angelina, but in the CFME provisioning dialog there's only ovirtmgmt.

I can provide the env upon request, please contact me.

Comment 8 Satoe Imaishi 2019-12-18 13:52:06 UTC
Boris, is there a new fix for this issue? If so, please provide PR link(s).

Comment 14 CFME Bot 2020-01-10 14:46:00 UTC
New commit detected on ManageIQ/manageiq-providers-ovirt/ivanchuk:

https://github.com/ManageIQ/manageiq-providers-ovirt/commit/8e466442f0966411666d79069458af1b0f62a493
commit 8e466442f0966411666d79069458af1b0f62a493
Author:     Boris Od <bodnopoz>
AuthorDate: Thu Jan  9 13:21:06 2020 -0500
Commit:     Boris Od <bodnopoz>
CommitDate: Thu Jan  9 13:21:06 2020 -0500

    Merge pull request #457 from agrare/fix_of_external_network_with_nil_id

    Fix for NICs that don't have a vnic_profile

    (cherry picked from commit 44a681f6c81d163308ae3da02368565963618309)

    https://bugzilla.redhat.com/show_bug.cgi?id=1767787

 app/models/manageiq/providers/redhat/inventory/parser/infra_manager.rb | 4 +-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comment 15 Angelina Vasileva 2020-01-16 13:10:21 UTC
Fixed and verified in 5.11.2.0.20200113212029_18edbd8.

All networks are displayed and VMs are provisioned to those networks.

Comment 17 errata-xmlrpc 2020-02-12 05:02:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0452


Note You need to log in before you can comment on or make changes to this bug.