Bug 1767954 - openshift/api verify job not catching missing regens
Summary: openshift/api verify job not catching missing regens
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: kube-apiserver
Version: 4.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 4.3.0
Assignee: Mike Dame
QA Contact: Xingxing Xia
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-11-01 17:51 UTC by Ben Parees
Modified: 2020-01-23 11:10 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-01-23 11:10:26 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift api pull 512 0 'None' closed Bug 1767954: Add CRDs to update and verify targets 2020-04-27 04:59:54 UTC
Red Hat Product Errata RHBA-2020:0062 0 None None None 2020-01-23 11:10:40 UTC

Description Ben Parees 2019-11-01 17:51:33 UTC
Description of problem:
https://github.com/openshift/api/pull/483

merged w/o updated generated content

it was fixed in  https://github.com/openshift/api/pull/507 but the verify job should have caught this in the original pr.

Comment 1 Mike Dame 2019-11-06 20:16:26 UTC
Oh, looks like I forgot to add any sort of regen checking to the verify script (https://github.com/openshift/api/blob/master/hack/verify-crds.sh)... will fix

Comment 3 Xingxing Xia 2019-11-11 12:03:10 UTC
Hi, not sure what issue this bug caused and not clear how to verify, could you share some hint? Thx

Comment 4 Ben Parees 2019-11-11 13:16:24 UTC
This was an issue with a CI job on the openshift/api repository in which the verify job didn't properly confirm that the PR included regenerated code.  I don't think QE needs to verify it, i'd rely on the developer who fixed the job to verify it manually (such as by submitting a PR that does not include regenerated code and confirming the verify job reports a failure).

Comment 5 Mike Dame 2019-11-11 14:31:33 UTC
I opened a test PR here: https://github.com/openshift/api/pull/514
Which successfully failed (hah) as expected: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_api/514/pull-ci-openshift-api-master-verify/1487

With that, I'm going to verify this manually as you said. Thanks!

Comment 7 errata-xmlrpc 2020-01-23 11:10:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0062


Note You need to log in before you can comment on or make changes to this bug.