Spec URL: https://hobbes1069.fedorapeople.org//opencascade.spec SRPM URL: https://hobbes1069.fedorapeople.org//opencascade-7.4.0-1.fc30.src.rpm Description: b'Open CASCADE Technology (OCCT) is a suite for 3D surface and solid\nmodeling, visualization, data exchange and rapid application development. It\nis an excellent platform for development of numerical simulation software\nincluding CAD/CAM/CAE, AEC and GIS, as well as PDM applications.'
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=38715543
=== Issues === - Sub-package are installed without license file except 'opencascade-foundation' - '-Wl,--as-needed' are linker flags already included for packaging: $ rpm --eval %__global_ldflags -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld Any reason for unsetting default linker flags? # Stop excessive linking that cmake projects are prone to. export LDFLAGS="-Wl,--as-needed" - %ldconfig_scriptlets are missing. - Please, remove macros in the comments. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [!]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [?]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in Cadence- debuginfo , Cadence-debugsource [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4720640 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. === rpmlint output ==== $ mock --no-clean -r fedora-rawhide-x86_64 --shell 'rpmlint opencascade-devel opencascade-draw opencascade-foundation opencascade-modeling opencascade-ocaf opencascade-visualization' INFO: mock.py version 1.4.20 starting (python version = 3.7.4)... Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Finish: chroot init Start: shell perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). opencascade-devel.x86_64: W: no-dependency-on opencascade/opencascade-libs/libopencascade opencascade-devel.x86_64: W: invalid-url URL: https://www.opencascade.com/content/overview <urlopen error [Errno -2] Name or service not known> opencascade-devel.x86_64: W: invalid-url BugURL: https://bugz.fedoraproject.org/opencascade <urlopen error [Errno -2] Name or service not known> opencascade-devel.x86_64: W: no-documentation opencascade-devel.x86_64: W: no-manual-page-for-binary custom.sh opencascade-devel.x86_64: W: no-manual-page-for-binary custom_gcc_64.sh opencascade-devel.x86_64: W: no-manual-page-for-binary draw.sh opencascade-devel.x86_64: W: no-manual-page-for-binary env.sh opencascade-draw.x86_64: W: description-shorter-than-summary opencascade-draw.x86_64: W: invalid-url URL: https://www.opencascade.com/content/overview <urlopen error [Errno -2] Name or service not known> opencascade-draw.x86_64: W: invalid-url BugURL: https://bugz.fedoraproject.org/opencascade <urlopen error [Errno -2] Name or service not known> opencascade-draw.x86_64: W: shared-lib-calls-exit /usr/lib64/libTKDraw.so.7.4.0 exit.5 opencascade-foundation.x86_64: W: invalid-url URL: https://www.opencascade.com/content/overview <urlopen error [Errno -2] Name or service not known> opencascade-foundation.x86_64: W: invalid-url BugURL: https://bugz.fedoraproject.org/opencascade <urlopen error [Errno -2] Name or service not known> opencascade-foundation.x86_64: W: shared-lib-calls-exit /usr/lib64/libTKernel.so.7.4.0 exit.5 opencascade-modeling.x86_64: W: invalid-url URL: https://www.opencascade.com/content/overview <urlopen error [Errno -2] Name or service not known> opencascade-modeling.x86_64: W: invalid-url BugURL: https://bugz.fedoraproject.org/opencascade <urlopen error [Errno -2] Name or service not known> opencascade-modeling.x86_64: W: no-documentation opencascade-ocaf.x86_64: W: invalid-url URL: https://www.opencascade.com/content/overview <urlopen error [Errno -2] Name or service not known> opencascade-ocaf.x86_64: W: invalid-url BugURL: https://bugz.fedoraproject.org/opencascade <urlopen error [Errno -2] Name or service not known> opencascade-ocaf.x86_64: W: no-documentation opencascade-visualization.x86_64: W: invalid-url URL: https://www.opencascade.com/content/overview <urlopen error [Errno -2] Name or service not known> opencascade-visualization.x86_64: W: invalid-url BugURL: https://bugz.fedoraproject.org/opencascade <urlopen error [Errno -2] Name or service not known> opencascade-visualization.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 24 warnings.
> - Sub-package are installed without license file except 'opencascade-foundation' I think this can be ignored since every packages should require that one with license files.
(In reply to Antonio from comment #2) > === Issues === > > - Sub-package are installed without license file except > 'opencascade-foundation' All the other packages should require the foundation package but I'll double check. > - '-Wl,--as-needed' are linker flags already included for packaging: > > $ rpm --eval %__global_ldflags > -Wl,-z,relro -Wl,--as-needed -Wl,-z,now > -specs=/usr/lib/rpm/redhat/redhat-hardened-ld > > Any reason for unsetting default linker flags? > > # Stop excessive linking that cmake projects are prone to. > export LDFLAGS="-Wl,--as-needed" This is all left over from the OCE package, I can remove it. > > - %ldconfig_scriptlets are missing. I'm pretty sure those are handled by file triggers now, no? > > - Please, remove macros in the comments. I assume you're talking about the source URL? I was of two minds on that one. Because a login is required to download the source I have to just list the source name but I wanted others to be able to piece together the download url (if it worked without a login).
>> >> - %ldconfig_scriptlets are missing. > > I'm pretty sure those are handled by file triggers now, no? Yes, it's true.
> I assume you're talking about the source URL? I was of two minds on that one. Because a login is required to download the source I have to just list the source > name but I wanted others to be able to piece together the download url (if it worked without a login). Okay, but those macros will be expanded uselessly unless you hide them with a double %: https://www.opencascade.com/sites/default/files/private/occt/OCC_%%{version}_release/%%{name}-&%{version}.tgz
(In reply to Richard Shaw from comment #4) > (In reply to Antonio from comment #2) > > === Issues === > > > > - Sub-package are installed without license file except > > 'opencascade-foundation' > > All the other packages should require the foundation package but I'll double > check. Verified, all subpackages require opencascade-foundation > > - '-Wl,--as-needed' are linker flags already included for packaging: > > > > $ rpm --eval %__global_ldflags > > -Wl,-z,relro -Wl,--as-needed -Wl,-z,now > > -specs=/usr/lib/rpm/redhat/redhat-hardened-ld > > > > Any reason for unsetting default linker flags? > > > > # Stop excessive linking that cmake projects are prone to. > > export LDFLAGS="-Wl,--as-needed" > > This is all left over from the OCE package, I can remove it. Removed. > > > > - Please, remove macros in the comments. I made them '%%' instead until I think of a better way of handling it.
Spec URL: https://hobbes1069.fedorapeople.org/opencascade.spec SRPM URL: https://hobbes1069.fedorapeople.org/opencascade-7.4.0-2.fc30.src.rpm * Mon Nov 04 2019 Richard Shaw <hobbes1069> - 7.4.0-2 - Update per reviewer requests.
Approved.
Thanks for the review!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/opencascade