Bug 1768333 - The ptp-operator deployment miss the tolerations by default
Summary: The ptp-operator deployment miss the tolerations by default
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 4.3.0
Assignee: zenghui.shi
QA Contact: huirwang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-11-04 06:00 UTC by huirwang
Modified: 2020-01-23 11:10 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-01-23 11:10:30 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift ptp-operator pull 13 0 'None' 'closed' 'BUG 1768333: allows operator be scheduled on master' 2019-12-05 15:43:14 UTC
Red Hat Product Errata RHBA-2020:0062 0 None None None 2020-01-23 11:10:40 UTC

Description huirwang 2019-11-04 06:00:20 UTC
Description of problem:
The ptp-operator deployment miss the tolerations by default

Version:
4.3.0-0.nightly-2019-10-31-003134


How to Reproduce:

1. Depoly PTP operator following the guide 
https://github.com/openshift/ptp-operator

2. Check ptp operator status

3. Check ptp operator deployment.

Actual Result:
huiran-mac:ptp-operator hrwang$ oc get pods -n openshift-ptp
NAME                            READY   STATUS    RESTARTS   AGE
ptp-operator-5d98757fff-hvz44   0/1     Pending   0          101m


ptp operator deployment, it missed the toleartion parts

        tolerations:
        - effect: NoSchedule
          key: node-role.kubernetes.io/master
          operator: Exists
          
huiran-mac:ptp-operator hrwang$ oc get deployments -n openshift-ptp -o yaml
apiVersion: v1
items:
- apiVersion: extensions/v1beta1
  kind: Deployment
  metadata:
    annotations:
      deployment.kubernetes.io/revision: "2"
      kubectl.kubernetes.io/last-applied-configuration: |
        {"apiVersion":"apps/v1","kind":"Deployment","metadata":{"annotations":{},"name":"ptp-operator","namespace":"openshift-ptp"},"spec":{"replicas":1,"selector":{"matchLabels":{"name":"ptp-operator"}},"template":{"metadata":{"labels":{"name":"ptp-operator"}},"spec":{"containers":[{"args":["ptp-operator --alsologtostderr -v 10"],"command":["/bin/bash","-c","--"],"env":[{"name":"WATCH_NAMESPACE","valueFrom":{"fieldRef":{"fieldPath":"metadata.namespace"}}},{"name":"POD_NAME","valueFrom":{"fieldRef":{"fieldPath":"metadata.name"}}},{"name":"OPERATOR_NAME","value":"ptp-operator"},{"name":"RELEASE_VERSION","value":"v4.3.0"},{"name":"LINUXPTP_DAEMON_IMAGE","value":"quay.io/openshift-release-dev/ocp-v4.0-art-dev:v4.3.0-201911010555-ose-ptp"}],"image":"quay.io/openshift-release-dev/ocp-v4.0-art-dev:v4.3.0-201910302317-ose-ptp-operator","imagePullPolicy":"IfNotPresent","name":"ptp-operator"}],"nodeSelector":{"node-role.kubernetes.io/master":""},"serviceAccountName":"ptp-operator"}}}}
    creationTimestamp: "2019-11-04T03:17:52Z"
    generation: 2
    labels:
      name: ptp-operator
    name: ptp-operator
    namespace: openshift-ptp
    resourceVersion: "1349740"
    selfLink: /apis/extensions/v1beta1/namespaces/openshift-ptp/deployments/ptp-operator
    uid: eeb2fdcf-eb00-405d-b05c-cee538909662
  spec:
    progressDeadlineSeconds: 600
    replicas: 1
    revisionHistoryLimit: 10
    selector:
      matchLabels:
        name: ptp-operator
    strategy:
      rollingUpdate:
        maxSurge: 25%
        maxUnavailable: 25%
      type: RollingUpdate
    template:
      metadata:
        creationTimestamp: null
        labels:
          name: ptp-operator
      spec:
        containers:
        - args:
          - ptp-operator --alsologtostderr -v 10
          command:
          - /bin/bash
          - -c
          - --
          env:
          - name: WATCH_NAMESPACE
            valueFrom:
              fieldRef:
                apiVersion: v1
                fieldPath: metadata.namespace
          - name: POD_NAME
            valueFrom:
              fieldRef:
                apiVersion: v1
                fieldPath: metadata.name
          - name: OPERATOR_NAME
            value: ptp-operator
          - name: RELEASE_VERSION
            value: v4.3.0
          - name: LINUXPTP_DAEMON_IMAGE
            value: quay.io/openshift-release-dev/ocp-v4.0-art-dev:v4.3.0-201911010555-ose-ptp
          image: quay.io/openshift-release-dev/ocp-v4.0-art-dev:v4.3.0-201910302317-ose-ptp-operator
          imagePullPolicy: IfNotPresent
          name: ptp-operator
          resources: {}
          terminationMessagePath: /dev/termination-log
          terminationMessagePolicy: File
        dnsPolicy: ClusterFirst
        nodeSelector:
          node-role.kubernetes.io/master: ""
        restartPolicy: Always
        schedulerName: default-scheduler
        securityContext: {}
        serviceAccount: ptp-operator
        serviceAccountName: ptp-operator
        terminationGracePeriodSeconds: 30

  status:
    availableReplicas: 1
    conditions:
    - lastTransitionTime: "2019-11-04T05:21:48Z"
      lastUpdateTime: "2019-11-04T05:21:48Z"
      message: Deployment has minimum availability.
      reason: MinimumReplicasAvailable
      status: "True"
      type: Available
    - lastTransitionTime: "2019-11-04T05:21:22Z"
      lastUpdateTime: "2019-11-04T05:21:48Z"
      message: ReplicaSet "ptp-operator-69d565978" has successfully progressed.
      reason: NewReplicaSetAvailable
      status: "True"
      type: Progressing
    observedGeneration: 2
    readyReplicas: 1
    replicas: 1
    updatedReplicas: 1
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""


Expected Result:
The ptp operator pod should be in running status by default.

Comment 1 zenghui.shi 2019-11-04 08:57:22 UTC
Hi Huiran, 

This has been fixed with commit: https://github.com/openshift/ptp-operator/commit/deaf8b45ba1364cd2981503eb32caac49415ade6
Could you please try with latest ptp-operator image (it should contain the fix bindata - linuxptp daemon template)?

Thanks!
Zenghui

Comment 4 huirwang 2019-11-12 06:49:17 UTC
Deployed ptp-operator with latest manifests from https://github.com/openshift/ptp-operator.  It worked.

huiran-mac:script hrwang$ oc get pods -n openshift-ptp
NAME                           READY   STATUS    RESTARTS   AGE
linuxptp-daemon-4jnnm          1/1     Running   0          21s
linuxptp-daemon-722gw          1/1     Running   0          21s
linuxptp-daemon-8tc77          1/1     Running   0          21s
linuxptp-daemon-jbfxz          1/1     Running   0          21s
linuxptp-daemon-wzlbb          1/1     Running   0          21s
ptp-operator-cccbfb46f-92wjw   1/1     Running   0          35s

Comment 6 errata-xmlrpc 2020-01-23 11:10:30 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0062


Note You need to log in before you can comment on or make changes to this bug.