Spec URL: https://jnovy.fedorapeople.org/oci-seccomp-bpf-hook.spec SRPM URL: https://jnovy.fedorapeople.org/oci-seccomp-bpf-hook-0.0.1-0.1.git3baa603a.fc31.src.rpm Description: oci-seccomp-bpf-hook provides a library for applications looking to use the Container Pod concept popularized by Kubernetes. Fedora Account System Username: jnovy
Updated spec and srpm with proper golang BRs: Spec URL: https://jnovy.fedorapeople.org/oci-seccomp-bpf-hook.spec SRPM URL: https://jnovy.fedorapeople.org/oci-seccomp-bpf-hook-0.0.1-0.2.git3baa603a.fc31.src.rpm
fedora-review run: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/lsm5/1768400-oci-seccomp-bpf-hook/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/containers/oci, /usr/share/containers/oci/hooks.d, /usr/share/containers, /usr/libexec/oci [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/libexec/oci/hooks.d(C, oci-kvm-hook, set, locale,, defaulting, oci-umount, Failed, to), /usr/share/doc/oci-seccomp-bpf-hook(C, set, locale,, defaulting, Failed, to), /usr/share/licenses/oci-seccomp-bpf-hook(C, set, locale,, defaulting, Failed, to) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define gobuild(o:) go build -tags="$BUILDTAGS" -ldflags "${LDFLAGS:-} -B 0x$(head -c20 /dev/urandom|od -An -tx1|tr -d ' \\n')" -a -v -x %{?**}; [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: oci-seccomp-bpf-hook-0.0.1-0.2.git3baa603a.fc32.x86_64.rpm oci-seccomp-bpf-hook-debuginfo-0.0.1-0.2.git3baa603a.fc32.x86_64.rpm oci-seccomp-bpf-hook-debugsource-0.0.1-0.2.git3baa603a.fc32.x86_64.rpm oci-seccomp-bpf-hook-0.0.1-0.2.git3baa603a.fc32.src.rpm oci-seccomp-bpf-hook.x86_64: W: spelling-error Summary(en_US) json -> son, j son, soon oci-seccomp-bpf-hook.x86_64: W: spelling-error Summary(en_US) syscalls -> miscalls oci-seccomp-bpf-hook.x86_64: W: spelling-error %description -l en_US json -> son, j son, soon oci-seccomp-bpf-hook.x86_64: W: spelling-error %description -l en_US syscalls -> miscalls oci-seccomp-bpf-hook.src: W: spelling-error Summary(en_US) json -> son, j son, soon oci-seccomp-bpf-hook.src: W: spelling-error Summary(en_US) syscalls -> miscalls oci-seccomp-bpf-hook.src: W: spelling-error %description -l en_US json -> son, j son, soon oci-seccomp-bpf-hook.src: W: spelling-error %description -l en_US syscalls -> miscalls 4 packages and 0 specfiles checked; 0 errors, 8 warnings. Rpmlint (debuginfo) ------------------- Checking: oci-seccomp-bpf-hook-debuginfo-0.0.1-0.2.git3baa603a.fc32.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_CA.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_CA.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). oci-seccomp-bpf-hook-debuginfo.x86_64: W: invalid-url URL: https://github.com/containers/oci-seccomp-bpf-hook <urlopen error [Errno -2] Name or service not known> oci-seccomp-bpf-hook-debugsource.x86_64: W: invalid-url URL: https://github.com/containers/oci-seccomp-bpf-hook <urlopen error [Errno -2] Name or service not known> oci-seccomp-bpf-hook.x86_64: W: spelling-error Summary(en_US) json -> son, j son, soon oci-seccomp-bpf-hook.x86_64: W: spelling-error Summary(en_US) syscalls -> miscalls oci-seccomp-bpf-hook.x86_64: W: spelling-error %description -l en_US json -> son, j son, soon oci-seccomp-bpf-hook.x86_64: W: spelling-error %description -l en_US syscalls -> miscalls oci-seccomp-bpf-hook.x86_64: W: invalid-url URL: https://github.com/containers/oci-seccomp-bpf-hook <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 0 errors, 7 warnings. Source checksums ---------------- https://github.com/containers/oci-seccomp-bpf-hook/archive/3baa603ae910f2aad29ea694b78b2f7f34b5d5ce/oci-seccomp-bpf-hook-3baa603a.tar.gz : CHECKSUM(SHA256) this package : c785b18673d6a40a2f2f6c6326eacb2d7ee472c05c4926ed4714f569d01f7be2 CHECKSUM(SHA256) upstream package : c785b18673d6a40a2f2f6c6326eacb2d7ee472c05c4926ed4714f569d01f7be2 Requires -------- oci-seccomp-bpf-hook (rpmlib, GLIBC filtered): libbcc.so.0()(64bit) libc.so.6()(64bit) libpthread.so.0()(64bit) libseccomp.so.2()(64bit) rtld(GNU_HASH) oci-seccomp-bpf-hook-debuginfo (rpmlib, GLIBC filtered): oci-seccomp-bpf-hook-debugsource (rpmlib, GLIBC filtered): Provides -------- oci-seccomp-bpf-hook: oci-seccomp-bpf-hook oci-seccomp-bpf-hook(x86-64) oci-seccomp-bpf-hook-debuginfo: debuginfo(build-id) oci-seccomp-bpf-hook-debuginfo oci-seccomp-bpf-hook-debuginfo(x86-64) oci-seccomp-bpf-hook-debugsource: oci-seccomp-bpf-hook-debugsource oci-seccomp-bpf-hook-debugsource(x86-64) Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -b 1768400 Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: Shell-api, Generic Disabled plugins: fonts, PHP, C/C++, Haskell, Java, Python, R, Perl, SugarActivity, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Updated license and used %gobuild: Spec URL: https://jnovy.fedorapeople.org/oci-seccomp-bpf-hook.spec SRPM URL: https://jnovy.fedorapeople.org/oci-seccomp-bpf-hook-0.0.1-0.3.git3baa603a.fc31.src.rpm
[x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/lsm5/1768400-oci-seccomp-bpf-hook/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/containers/oci, /usr/share/containers/oci/hooks.d, /usr/share/containers, /usr/libexec/oci -- These are owned by oci-umount and containers-common [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/libexec/oci/hooks.d(C, oci-kvm-hook, set, locale,, defaulting, oci-umount, Failed, to), /usr/share/doc/oci-seccomp-bpf-hook(C, set, locale,, defaulting, Failed, to), /usr/share/licenses/oci-seccomp-bpf-hook(C, set, locale,, defaulting, Failed, to) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/oci-seccomp-bpf-hook