Spec URL: https://copr-be.cloud.fedoraproject.org/results/akhaitov/python-typing-inspect/fedora-rawhide-x86_64/01085854-python-typing-inspect/python-typing-inspect.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/akhaitov/python-typing-inspect/fedora-rawhide-x86_64/01085854-python-typing-inspect/python-typing-inspect-0.5.0-1.fc32.src.rpm Description: The "typing_inspect" module defines experimental API for runtime inspection of types defined in the standard "typing" module. Fedora Account System Username: akhaitov
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=38757880
The URL for the Source0 does not work, because the file is saved on PyPI with an underscore (typing_inspect instead of typing-inspect). We have to give the %pypi_source macro a parameter. I suggest this: Define a new macro at the top of the file: %global pypi_srcname typing_inspect And then use it in pypi_source call: Source0: %{pypi_source %{pypi_srcname}} You can then use the new macro in several other places to avoid duplication.
Issues ====== - Wrong Source0 link - The source tarball included in the SRPM is named differently than the one downloaded from PyPI (which uses `_`) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Binary eggs must be removed in %prep [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://files.pythonhosted.org/packages/source/t/typing- inspect/typing-inspect-0.5.0.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [!]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-typing-inspect-0.5.0-1.fc32.noarch.rpm python-typing-inspect-0.5.0-1.fc32.src.rpm python-typing-inspect.src: W: invalid-url Source0: https://files.pythonhosted.org/packages/source/t/typing-inspect/typing-inspect-0.5.0.tar.gz HTTP Error 404: Not Found 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). python3-typing-inspect.noarch: W: invalid-url URL: https://github.com/ilevkivskyi/typing_inspect <urlopen error [Errno -2] Name or service not known> 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- python3-typing-inspect (rpmlib, GLIBC filtered): python(abi) python3.8dist(mypy-extensions) python3.8dist(typing-extensions) python3dist(mypy-extensions) python3dist(typing-extensions) Provides -------- python3-typing-inspect: python-typing-inspect python3-typing-inspect python3.8dist(typing-inspect) python3dist(typing-inspect) Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -b 1768490 Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: Shell-api, Generic, Python Disabled plugins: Java, Ocaml, Haskell, SugarActivity, R, C/C++, PHP, Perl, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Anna is trying to become a Fedora packager and I have agreed to act as her sponsor.
- Fixed Source0 URL - Fixed .tar.gz name to be consistent with PyPI Spec URL: https://copr-be.cloud.fedoraproject.org/results/akhaitov/python-typing-inspect/fedora-rawhide-x86_64/01091958-python-typing-inspect/python-typing-inspect.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/akhaitov/python-typing-inspect/fedora-rawhide-x86_64/01091958-python-typing-inspect/python-typing-inspect-0.5.0-1.fc32.src.rpm Koji task: https://koji.fedoraproject.org/koji/taskinfo?taskID=38922036
The changes look good. The Source link and tarball name have been fixed, and previously failed checks now pass: [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. Everything checks out, therefore I'm approving this request!
And I've sponsored Anna into the Fedora packages group, congratulations!
Hi Anna, the procedure is that when you build the package in Fedora, you can close this bug. So if everything is in order, do Status: CLOSED RAWHIDE if it's built only in Rawhide, or CLOSED CURRENTRELEASE if it's also in any other Fedora branch. Let me know if you have any questions :)
Well, I closed it by accident myself, apologies :)
Damn, and now I reverted it back, because it is not yet built it seems. It seems the automation that creates the component didn't kick in yet?
Hi Anna, so it turnsout this is not yet automated, I was too hopeful :) So you have to go and request a git module and branches yourself. Follow the manual from Step 7: https://fedoraproject.org/wiki/New_package_process_for_existing_contributors
Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.
This bug was accidentally closed due to a query error. Reopening.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-typing-inspect