Description of problem:

When configuring ips via pod annotation, SR-IOV injector cannot parse net-attach-def with an array of ip list, which result in SR-IOV resource request/limit not be injected in pod spec. The pod can still be created successfully, but no SR-IOV interface is attached.


Version-Release number of selected component (if applicable):
4.3.0

How reproducible:
Always

Steps to Reproduce:

Assuming SR-IOV devices have been exposed to kubelet with resource name as 'openshift.io/intelnics'

1. create sriov-net1 net-attach-def via SR-IOV Network Operator

apiVersion: sriovnetwork.openshift.io/v1
kind: SriovNetwork
metadata:
  name: sriov-net1
  namespace: openshift-sriov-network-operator
spec:
  ipam: |
    {
      "type": "static"
    }
  vlan: 0
  resourceName: intelnics
  networkNamespace: default



2. use pod spec below:

apiVersion: v1
kind: Pod
metadata:
  name: testpod1
  annotations:
    k8s.v1.cni.cncf.io/networks: '[
        {
                "name": "sriov-net1",
                "mac": "CA:FE:C0:FF:EE:00",
                "ips": ["192.168.100.101/24", "2001::2/64"]
        }
]'
spec:
  containers:
  - name: appcntr1
    image: zenghui/centos-dpdk
    imagePullPolicy: IfNotPresent
    command: [ "/bin/bash", "-c", "--" ]
    args: [ "while true; do sleep 300000; done;" ]
    resources:
      requests:
        cpu: '1'
        memory: 100Mi
      limits:
        cpu: '1'
        memory: 100Mi

3. check SR-IOV injector log

Actual results:


Expected results:


Additional info:

SR-IOV injector log:

I1105 12:25:25.020446       1 main.go:36] starting mutating admission controller for network resources injection
I1105 12:34:49.678308       1 webhook.go:332] Received mutation request
I1105 12:34:49.685541       1 webhook.go:157] '[ { "name": "sriov-intel", "mac": "CA:FE:C0:FF:EE:01", "ips": ["192.168.100.102/24", "2001::1/64"] } ]' is not in JSON format: json: cannot unmarshal array into Go struct field NetworkSelectionElement.ips of type string... trying to parse as comma separated network selections list
I1105 12:34:49.685700       1 webhook.go:217] at least one of the network selection units is invalid: error found at '[ { "name": "sriov-intel"'
E1105 12:34:49.685721       1 webhook.go:163] error parsing network selection element: at least one of the network selection units is invalid: error found at '[ { "name": "sriov-intel"'
I1105 12:34:49.686894       1 webhook.go:391] pod doesn't need any custom network resources
I1105 12:34:49.686928       1 webhook.go:257] sending response to the Kubernetes API server
I1105 12:37:33.286741       1 webhook.go:332] Received mutation request
I1105 12:37:33.305374       1 webhook.go:371] network attachment definition 'default/sriov-intel' found
I1105 12:37:33.305413       1 webhook.go:377] resource 'openshift.io/intelnics' needs to be requested for network 'default/sriov-intel'
I1105 12:37:33.305441       1 webhook.go:422] patch after all mutations%!(EXTRA []webhook.jsonPatchOperation=[{add /spec/containers/0/resources/requests/openshift.io~1intelnics {{1 0} {<nil>}  DecimalSI}} {add /spec/containers/0/resources/limits/openshift.io~1intelnics {{1 0} {<nil>}  DecimalSI}} {add /spec/containers/0/volumeMounts/- {podnetinfo false /etc/podnetinfo  <nil> }} {add /spec/volumes/- {podnetinfo {nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil &DownwardAPIVolumeSource{Items:[{labels ObjectFieldSelector{APIVersion:,FieldPath:metadata.labels,} nil <nil>} {annotations &ObjectFieldSelector{APIVersion:,FieldPath:metadata.annotations,} nil <nil>}],DefaultMode:nil,} nil nil nil nil nil nil nil nil nil nil nil nil}}}])
I1105 12:37:33.307473       1 webhook.go:257] sending response to the Kubernetes API server