Bug 1769465 - Request to enable CONFIG_KEYBOARD_APPLESPI module in kernel 5.3.x
Summary: Request to enable CONFIG_KEYBOARD_APPLESPI module in kernel 5.3.x
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: 31
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Kernel Maintainer List
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-11-06 16:53 UTC by Leif Liddy
Modified: 2019-11-16 14:08 UTC (History)
19 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-16 14:08:15 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Leif Liddy 2019-11-06 16:53:15 UTC
Description of problem:


CONFIG_KEYBOARD_APPLESPI is not set in the Fedora 5.3.x kernel config


Version-Release number of selected component (if applicable):
kernel 5.3.x


Steps to Reproduce:

grep CONFIG_KEYBOARD_APPLESPI /boot/config-5.3.8-300.fc31.x86_64
# CONFIG_KEYBOARD_APPLESPI is not set



Additional info:
Requesting that CONFIG_KEYBOARD_APPLESPI gets included as a kernel module in the Fedora kernel. 
This kernel module allows the keyboard + trackpad to function on the 12" MacBook (MacBook8,1, MacBook9,1, and MacBook 10,1) and 2016 through 2018 Macbook Pro's (MacBookPro13,* and 14,*).


Current apple spi driver projects:
https://github.com/cb22/macbook12-spi-driver
https://github.com/roadrunner2/macbook12-spi-driver

I, along with many other have been waiting over 3 years for this driver to get included into the linux kernel. Now, that support has finally been added to mainline, it's a bit of a let down that Fedora has decided not to include support for it. I'm not sure if that was a conscientious decision or not. I'm just humbling requesting that the Fedora team reconsider adding support. It's an absolute nightmare attempting to explain to non-technical people how to create a (fedora) live usb image with persistent storage, then to connect an external keyboard + mouse, upgrade the kernel, install kernel headers, download apple spi keyboard driver, compile it....etc. Whereas it could just work out-of-the-box. The keyboard and trackpad are pretty fundamental drivers to have on a laptop.

Comment 1 Jeremy Cline 2019-11-07 16:39:25 UTC
Hi Leif,

Thanks for the report. I've flipped it on for Rawhide (it's in https://koji.fedoraproject.org/koji/taskinfo?taskID=38828158) and it should arrive in stable with v5.3.10. It'll still be broken in the F31 installation media, sadly, but at least an update will fix things and F32 will work out of the box. The update system should close out this bug when the update arrives in stable repositories.

Comment 2 Leif Liddy 2019-11-07 21:55:11 UTC
That's perfect!
The only that's needed now is to add this (and associated modules) to the initramfs image. 
**needed to be able to enter password to decrypt luks-encrypted partition at boot time. 


#necessary dracut config  
add_drivers+="applespi spi_pxa2xx_platform intel_lpss_pci"

I can another ticket for this, but I'll wait until fedora kernel 5.3.10 is released first. 

Thanks for your help (and quick response) :)

Comment 3 Leif Liddy 2019-11-16 14:04:23 UTC
Support for CONFIG_KEYBOARD_APPLESPI has been added. Keyboard + trackpad work perfectly with the driver. Should I close out the ticket?


Note You need to log in before you can comment on or make changes to this bug.