Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://fedorapeople.org/~walters/fsverity-utils.spec SRPM URL: https://fedorapeople.org/~walters/fsverity-utils-1.0-1.fc30.src.rpm Description: This is fsverity, a userspace utility for fs-verity. fs-verity is a Linux kernel feature that does transparent on-demand integrity/authenticity verification of the contents of read-only files, using a hidden Merkle tree (hash tree) associated with the file. The mechanism is similar to dm-verity, but implemented at the file level rather than at the block device level. The fsverity utility allows you to set up fs-verity protected files. Fedora Account System Username: walters
xref https://lore.kernel.org/linux-fscrypt/20191106184332.GC2766@sol.localdomain/
There's some sort of weird permissions issue, see https://fedorapeople.org/~walters/fsverity-utils.spec2 for the spec.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: fsverity-utils-1.0-1.fc32.x86_64.rpm fsverity-utils-debuginfo-1.0-1.fc32.x86_64.rpm fsverity-utils-debugsource-1.0-1.fc32.x86_64.rpm fsverity-utils-1.0-1.fc32.src.rpm fsverity-utils.x86_64: W: summary-not-capitalized C fsverity utilities fsverity-utils.x86_64: W: spelling-error %description -l en_US fs -> sf, gs, fa fsverity-utils.x86_64: W: spelling-error %description -l en_US dm -> d, m, dim fsverity-utils.x86_64: E: no-changelogname-tag fsverity-utils.x86_64: W: no-manual-page-for-binary fsverity fsverity-utils-debuginfo.x86_64: E: no-changelogname-tag fsverity-utils-debugsource.x86_64: E: no-changelogname-tag fsverity-utils.src: W: summary-not-capitalized C fsverity utilities fsverity-utils.src: W: spelling-error %description -l en_US fs -> sf, gs, fa fsverity-utils.src: W: spelling-error %description -l en_US dm -> d, m, dim fsverity-utils.src: E: no-changelogname-tag fsverity-utils.src: W: strange-permission fsverity-utils.spec 600 4 packages and 0 specfiles checked; 4 errors, 8 warnings. Rpmlint (debuginfo) ------------------- Checking: fsverity-utils-debuginfo-1.0-1.fc32.x86_64.rpm fsverity-utils-debuginfo.x86_64: E: no-changelogname-tag 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). fsverity-utils.x86_64: W: summary-not-capitalized C fsverity utilities fsverity-utils.x86_64: W: spelling-error %description -l en_US fs -> sf, gs, fa fsverity-utils.x86_64: W: spelling-error %description -l en_US dm -> d, m, dim fsverity-utils.x86_64: E: no-changelogname-tag fsverity-utils.x86_64: W: invalid-url URL: https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/fsverity-utils.git <urlopen error [Errno -2] Name or service not known> fsverity-utils.x86_64: W: no-manual-page-for-binary fsverity fsverity-utils-debuginfo.x86_64: E: no-changelogname-tag fsverity-utils-debuginfo.x86_64: W: invalid-url URL: https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/fsverity-utils.git <urlopen error [Errno -2] Name or service not known> fsverity-utils-debugsource.x86_64: E: no-changelogname-tag fsverity-utils-debugsource.x86_64: W: invalid-url URL: https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/fsverity-utils.git <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 3 errors, 7 warnings. Source checksums ---------------- https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/fsverity-utils.git/snapshot/fsverity-utils-1.0.tar.gz : CHECKSUM(SHA256) this package : 17a501d6e7f296e74d22af7558dcceca1963bd6d14231a08ba7e4d9bf8e6e1da CHECKSUM(SHA256) upstream package : 17a501d6e7f296e74d22af7558dcceca1963bd6d14231a08ba7e4d9bf8e6e1da Requires -------- fsverity-utils (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.1.1()(64bit) libcrypto.so.1.1(OPENSSL_1_1_0)(64bit) rtld(GNU_HASH) fsverity-utils-debuginfo (rpmlib, GLIBC filtered): fsverity-utils-debugsource (rpmlib, GLIBC filtered): Provides -------- fsverity-utils: fsverity-utils fsverity-utils(x86-64) fsverity-utils-debuginfo: debuginfo(build-id) fsverity-utils-debuginfo fsverity-utils-debuginfo(x86-64) fsverity-utils-debugsource: fsverity-utils-debugsource fsverity-utils-debugsource(x86-64) Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -r -b 1769861 Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: Shell-api, C/C++, Generic Disabled plugins: Java, Haskell, SugarActivity, fonts, Ocaml, PHP, Python, R, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Colin Walters, It lacks a changelog entry in the spec file, but everything else seems fine to me. Jes
Right, I don't think RPM changelogs make sense in the spec files, so I don't add them until forced to by the Fedora SCM process.
I see, I flagged it since the fedora-review tool complains about it. It's not a big deal for me.
I added one anyways in the latest https://fedorapeople.org/~walters/fsverity-utils.spec2
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: fsverity-utils-1.0-1.fc32.x86_64.rpm fsverity-utils-debuginfo-1.0-1.fc32.x86_64.rpm fsverity-utils-debugsource-1.0-1.fc32.x86_64.rpm fsverity-utils-1.0-1.fc32.src.rpm fsverity-utils.x86_64: W: summary-not-capitalized C fsverity utilities fsverity-utils.x86_64: W: spelling-error %description -l en_US fs -> sf, gs, fa fsverity-utils.x86_64: W: spelling-error %description -l en_US dm -> d, m, dim fsverity-utils.x86_64: W: no-manual-page-for-binary fsverity fsverity-utils.src: W: summary-not-capitalized C fsverity utilities fsverity-utils.src: W: spelling-error %description -l en_US fs -> sf, gs, fa fsverity-utils.src: W: spelling-error %description -l en_US dm -> d, m, dim 4 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (debuginfo) ------------------- Checking: fsverity-utils-debuginfo-1.0-1.fc32.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). fsverity-utils.x86_64: W: summary-not-capitalized C fsverity utilities fsverity-utils.x86_64: W: spelling-error %description -l en_US fs -> sf, gs, fa fsverity-utils.x86_64: W: spelling-error %description -l en_US dm -> d, m, dim fsverity-utils.x86_64: W: invalid-url URL: https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/fsverity-utils.git <urlopen error [Errno -2] Name or service not known> fsverity-utils.x86_64: W: no-manual-page-for-binary fsverity fsverity-utils-debugsource.x86_64: W: invalid-url URL: https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/fsverity-utils.git <urlopen error [Errno -2] Name or service not known> fsverity-utils-debuginfo.x86_64: W: invalid-url URL: https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/fsverity-utils.git <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 0 errors, 7 warnings. Source checksums ---------------- https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/fsverity-utils.git/snapshot/fsverity-utils-1.0.tar.gz : CHECKSUM(SHA256) this package : 17a501d6e7f296e74d22af7558dcceca1963bd6d14231a08ba7e4d9bf8e6e1da CHECKSUM(SHA256) upstream package : 17a501d6e7f296e74d22af7558dcceca1963bd6d14231a08ba7e4d9bf8e6e1da Requires -------- fsverity-utils (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.1.1()(64bit) libcrypto.so.1.1(OPENSSL_1_1_0)(64bit) rtld(GNU_HASH) fsverity-utils-debuginfo (rpmlib, GLIBC filtered): fsverity-utils-debugsource (rpmlib, GLIBC filtered): Provides -------- fsverity-utils: fsverity-utils fsverity-utils(x86-64) fsverity-utils-debuginfo: debuginfo(build-id) fsverity-utils-debuginfo fsverity-utils-debuginfo(x86-64) fsverity-utils-debugsource: fsverity-utils-debugsource fsverity-utils-debugsource(x86-64) Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -b 1769861 -r Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: Shell-api, C/C++, Generic Disabled plugins: PHP, Python, SugarActivity, Haskell, Java, Ocaml, Perl, fonts, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fsverity-utils