Bug 17713 - GRECORD sets the incorrect channel (mono/stereo) when recording mono
GRECORD sets the incorrect channel (mono/stereo) when recording mono
Status: CLOSED RAWHIDE
Product: Red Hat Linux
Classification: Retired
Component: gnome-media (Show other bugs)
6.2
i386 Linux
medium Severity medium
: ---
: ---
Assigned To: Havoc Pennington
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2000-09-19 12:57 EDT by Tom Woller
Modified: 2008-05-01 11:37 EDT (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2000-10-23 14:52:08 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Tom Woller 2000-09-19 12:57:51 EDT
GRECORD sets the incorrect channel (mono/stereo) when recording mono. the 
problem is a local variable that is the same name as a global.  the global 
channel value is corrupted with the ESD_STEREO definition (bit field not a 
binary 0/1 value).  problem appears after playing back recorded data, the 
audio is distorted.

patch for grec.c in GRECORD 0.3.4:

--- grec.c	Mon Sep 18 10:13:54 2000
+++ grec.c.fix	Mon Sep 18 10:13:45 2000
@@ -528,7 +528,7 @@
 	gint length = 0;
 	
 	gint bits = ESD_BITS16;
-	gint channels = ESD_STEREO;
+	gint esd_channels = ESD_STEREO;
 	gint mode = ESD_STREAM;
 	gint func = ESD_RECORD;
 	esd_format_t format = 0;
@@ -551,7 +551,7 @@
 
 	rate = atoi (samplerate);
 
-	format = bits | channels | mode | func;
+	format = bits | esd_channels | mode | func;
 	sock = esd_record_stream_fallback (format, rate, host, name);
 	
 	if (sock <= 0)
Comment 1 Harald Hoyer 2000-10-13 09:52:05 EDT
grecord is in gnome-media :)
Comment 2 Elliot Lee 2001-01-31 19:37:52 EST
fixed in gnome-media-1.2.0-10

Note You need to log in before you can comment on or make changes to this bug.