Spec: http://rpm.greysector.net/extras/mkvtoolnix.spec SRPM: http://rpm.greysector.net/extras/mkvtoolnix-1.6.5-2.src.rpm Description: Mkvtoolnix is a set of utilities to mux and demux audio, video and subtitle streams into and from Matroska containers.
Legal review needed; the tarball includes some mpeg/mp3/dts/aac related code which is also built into the binaries. (In the meantime: a desktop entry for the GUI would be nice, and $RPM_OPT_FLAGS honoring by stripping hardcoded -O3, see eg. http://cachalot.mine.nu/5/SRPMS/mkvtoolnix-1.6.5-0.1.src.rpm)
It doesn't decode video or audio, just demuxes and remuxes it into mkv. I hope it's allright. Both your suggestions are now included.
What is the best way to ask for Legal review ? Is there a tracker bug to add ?
Partial review while waiting for legal comments: - Change BR wxGTK2-devel to wxGTK-devel; the former is ambiguous with the wxGTK-devel and compat-wxGTK2-devel both providing it. - Unowned %{_datadir}/%{name} directory - (rpmlint:) Group tag for -gui should be changed to Applications/Multimedia - (rpmlint:) too long lines in %description, word-wrap at < 80 chars - FLAC support missing, adding BR: flac-devel >= 1.1.1 fixes it - Why disable bzip2 by default? Even rpm itself requires bzip2-libs so it won't add any dependency bloat. The same goes kind of with lzo in the sense that some popular multimedia packages which are somewhat likely to be installed on systems where this is require it, and it doesn't add any other deps, so I think it wouldn't hurt. If there's a good use case for having these disabled by default (or in the first place), please add a comment explaining it in the specfile.
I can't just change wxGTK2-devel to wxGTK-devel, because it'll build against gtk+-1.x on FC4. I've included a conditional BR using %{fedora}. Everything else is fixed. http://rpm.greysector.net/extras/mkvtoolnix-1.6.5-3.src.rpm
Dropping FE-NEEDSPONSOR. Tom Callaway offered sponsorship in bug 177235 (and bugzilla change-several-bugs-at-once feature requires me to add/edit something).
uhm, bugzilla is broken :(
Everything enabled, updated to 1.7.0. http://rpm.greysector.net/extras/mkvtoolnix-1.7.0-1.src.rpm http://rpm.greysector.net/extras/mkvtoolnix.spec
Also, any word from legal yet?
Nope :(
Posted a question to http://fedoraproject.org/wiki/FedoraLegalIssues to keep track of this.
I really don't think this package can get Fedora Legal approval as-is, and removing any of its demuxing capabilities will reduce its usefulness. I've packaged it too, outside of Extras for now. Regarding the package currently under review : - The "buildroot != /" check in %install is not needed - Passing STRIP=/bin/true to make install will fix the empty debuginfo package - sed is in the build requirements exceptions (no need to list it) (*) - The gui sub-package should probably require the current version-release - Maybe the "base64tool" should be considered to have a too generic name and have it changed to something like "mkvbase64tool" or "mkvb64tool"? (*) I assume it's listed because the version is required for inline replacing
http://rpm.greysector.net/extras/mkvtoolnix-1.8.0-1.src.rpm http://rpm.greysector.net/extras/mkvtoolnix.spec Included all Matthias' suggestions (except renaming base64tool).
Lifting FE-Legal, after discussion with Max. I was unable to find any patents around the process of muxing/demuxing (not the hardware implementations of muxing/demuxing).
http://rpm.greysector.net/extras/mkvtoolnix-1.8.1-1.src.rpm http://rpm.greysector.net/extras/mkvtoolnix.spec Updated to 1.8.1 + some fixes by Ville and myself.
Nothing to add, approved. Even if "base64tool" is a genericish name for a tool, all references to it I could find from some searching referred to this particular one, so I'm fine with dealing with it later if there's ever need to do so.
Imported and built for devel, FC-5 and FC-6 branches requested. Thanks!