Bug 177166 - Review Request: perl-Compress-Bzip2 - Interface to Bzip2 compression library
Summary: Review Request: perl-Compress-Bzip2 - Interface to Bzip2 compression library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ville Skyttä
QA Contact: David Lawrence
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-01-06 20:25 UTC by Jose Pedro Oliveira
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-02-18 16:10:08 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jose Pedro Oliveira 2006-01-06 20:25:19 UTC
Spec Name or Url:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Compress-Bzip2.spec

SRPM Name or Url:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Compress-Bzip2-2.09-1.src.rpm

Description:
The Compress::Bzip2 module provides a Perl interface to the Bzip2
compression library.  A relevant subset of the functionality provided
by Bzip2 is available in Compress::Bzip2.

All string parameters can either be a scalar or a scalar reference.

The module can be split into two general areas of functionality,
namely in-memory compression/decompression and read/write access
to bzip2 files.

Comment 1 Ville Skyttä 2006-01-07 22:29:11 UTC
Approved, with a few notes for consideration:

- Trim down %description, the first paragraph should be fine.
- Make sure that the bundled bzip2 source will never be used, by
  rm -rf'ing bzlib-src in %prep or something like that.
- Include ANNOUNCE in %docs

Comment 2 Jose Pedro Oliveira 2006-01-09 16:28:17 UTC
(In reply to comment #1)
> Approved, with a few notes for consideration:
> 
> - Trim down %description, the first paragraph should be fine.

Done.

> - Make sure that the bundled bzip2 source will never be used, by
>   rm -rf'ing bzlib-src in %prep or something like that.

Just removing the bundled bzip2 source directory causes too many
problems: missing files in manisfest list (W) and test failures (E).
Will look into it tonight or tomorrow.

> - Include ANNOUNCE in %docs

Done.

Comment 3 Ville Skyttä 2006-02-17 22:47:19 UTC
This package has been in the repo for some time now.  Is this report being kept
open intentionally?

Comment 4 Jose Pedro Oliveira 2006-02-18 16:10:08 UTC
Ville,

I kept it opened in order to remember to look into the second item of your list
in comment #1 (just added a item in my FE task list).

Closing ticket.

jpo


Note You need to log in before you can comment on or make changes to this bug.