Bug 1771750 - Review Request: python3-libcomps - Python 3 bindings for libcomps library
Summary: Review Request: python3-libcomps - Python 3 bindings for libcomps library
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2019-11-12 21:57 UTC by Michael DePaulo
Modified: 2022-01-17 00:45 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-01-17 00:45:20 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Michael DePaulo 2019-11-12 21:57:42 UTC
Spec URL: https://github.com/mikedep333/libcomps-rpm/blob/c7-py3-bindings-only/python3-libcomps.spec
SRPM URL: https://copr.fedorainfracloud.org/coprs/mikedep333/pulp_rpm_deps/package/python3-libcomps/
Description: Python 3 bindings for libcomps library
Fedora Account System Username: mikedep333

*This is an EPEL7 only package.*

This is a follow up to this thread:
"Missing Python 3 bindings for C libraries in EL7"
https://lists.fedoraproject.org/archives/list/epel-devel@lists.fedoraproject.org/thread/RIXJ3VPR27NVATQJWI4O2UCMFVL7WHEJ/

Comment 1 Neal Gompa 2019-11-12 22:05:36 UTC
This package cannot be added to EPEL7, as it will conflict with EL7's libcomps package, due to it providing the libcomps.so.* libraries.

Comment 2 Neal Gompa 2019-11-12 22:09:20 UTC
Significant tweaking will need to be done to make this work. Either a patch will be required to make the library build statically into the Python module library, or the soname needs to be changed so that it isn't conflicting with the libcomps package.

Comment 3 Michael DePaulo 2019-11-12 23:39:53 UTC
Neal, I made it exclude those files. They are merely built as a byproduct. It depends on the original "libcomps" RPM. Is this acceptable?

[mdepaulo@mdepaulo libcomps]$ rpm -qlp python36-libcomps-0.1.8-12.el7.x86_64.rpm
/usr/lib64/python3.6/site-packages/libcomps
/usr/lib64/python3.6/site-packages/libcomps/__init__.py
/usr/lib64/python3.6/site-packages/libcomps/__pycache__
/usr/lib64/python3.6/site-packages/libcomps/__pycache__/__init__.cpython-36.opt-1.pyc
/usr/lib64/python3.6/site-packages/libcomps/__pycache__/__init__.cpython-36.pyc
/usr/lib64/python3.6/site-packages/libcomps/_libpycomps.so
/usr/share/doc/python36-libcomps-0.1.8
/usr/share/doc/python36-libcomps-0.1.8/README.md
/usr/share/licenses/python36-libcomps-0.1.8
/usr/share/licenses/python36-libcomps-0.1.8/COPYING

I did push a new commit a little while ago, to adapt to the example more of python3-rpm. Particularly for the binary PRM being "python36-libcomps".

I realized that I still have a little more work to do on the egg-info (for the Pulp project's needs.) I am working on a PR to upstream libcomps for that, then I'll backport it as a patch for the packaging. We did the same thing for createrepo_c.

Comment 4 Michael DePaulo 2019-11-15 15:16:23 UTC
Neal,

FYI: On the Pulp team, we are currently pausing working on this.

We are debating whether to use this bindings-only RPM, or finishing creating & putting a "libcomps" pip/scikit-build package on PyPI that includes building the C library. (like we did for createrepo_c)

I may finish this contribution to EPEL7, but I would do it in my free time within 2 weeks or so.

-Mike

Comment 5 Neal Gompa 2019-11-19 11:34:44 UTC
This spec seems fine, but I can't run it through fedora-review because you're linking to html pages. Can you please provide direct links?

Comment 6 Neal Gompa 2019-11-19 11:38:18 UTC
> Requires:       %{orig_name}% = %{version}
> Requires:       %{orig_name}% >= %{version}-%{release}

You probably don't want to specifically do "Requires: %orig_name >= %version-%release" there, as it's quite likely that will have unintended consequences as this package gets updated out of band.

You probably want a Conflicts stanza:

Conflicts: %{orig_name} < 0.1.8-12

That way, this doesn't break if the release goes out of sync.

Comment 7 Mattia Verga 2021-12-17 17:11:12 UTC
Review seems stuck, resetting status and setting the NEEDINFO flag against the submitter.
Micheal are you still interested in this?

Comment 8 Package Review 2022-01-17 00:45:20 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.