Bug 177211 - Review Request: newsx - NNTP news exchange utility
Summary: Review Request: newsx - NNTP news exchange utility
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-01-07 17:11 UTC by Dominik 'Rathann' Mierzejewski
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

(edit)
Clone Of:
(edit)
Last Closed: 2006-10-01 12:36:21 UTC


Attachments (Terms of Use)

Description Dominik 'Rathann' Mierzejewski 2006-01-07 17:11:44 UTC
Spec Name or Url: http://rpm.greysector.net/extras/newsx.spec
SRPM Name or Url: http://rpm.greysector.net/extras/newsx-1.6-1.src.rpm
Description:
Newsx is an NNTP client that will connect to a remote NNTP server and
post outgoing news articles batched by the news system (e.g. INN), as
well as fetch incoming articles.

Comment 1 Jochen Schmitt 2006-02-22 18:57:56 UTC
God:
+ rpm for srpm worked fine.
+ Local build worked fine.
Bad:
- rpmlint binary rpm complaints:

rpmlint newsx-1.6-1.i686.rpm
E: newsx non-standard-dir-perm /var/spool/news/inhosts 0770

- Please use %{?dist} in Release tag.
- Mock build failed.

Unfortunately I have not the rights to sponsor you.




Comment 2 Dominik 'Rathann' Mierzejewski 2006-04-02 22:05:17 UTC
http://rpm.greysector.net/extras/newsx.spec
http://rpm.greysector.net/extras/newsx-1.6-2.src.rpm

Should be fixed now.

Comment 3 John Mahowald 2006-04-07 06:13:00 UTC
Build failed.

checking history... ERROR: cannot determine hash mode of /var/lib/news/history
Try running makehistory first.

There's a good chance your Requires line is not needed. rpm can figure out from
the BuildRequires that it needs inn.

Comment 4 John Mahowald 2006-07-26 02:29:34 UTC
Ping.

Adding --without-history to %configure results in a build.

What's this Provides:	news-sucker  line?

Comment 5 Dominik 'Rathann' Mierzejewski 2006-07-28 17:48:51 UTC
I can't reproduce that failure on FC5 box. I've dropped that Provides: line, but
I think Requires: inn should be kept, because newsx doesn't depend on any inn
libs directly.

http://rpm.greysector.net/extras/newsx.spec
http://rpm.greysector.net/extras/newsx-1.6-3.src.rpm


Comment 6 Dominik 'Rathann' Mierzejewski 2006-08-08 11:47:38 UTC
*ping*

Comment 7 John Mahowald 2006-08-14 13:52:57 UTC
Building with mock on both FC5 and FC6 I still get 

checking history... ERROR: cannot determine hash mode of /var/lib/news/history
Try running makehistory first.

Adding --without-history to configure does make it build.

Comment 8 Dominik 'Rathann' Mierzejewski 2006-09-02 16:28:57 UTC
Builds fine in both fc6 and fc5 mock here.

Comment 9 Dominik 'Rathann' Mierzejewski 2006-09-27 21:40:19 UTC
*ping*?

Comment 10 Stewart Adam 2006-09-27 23:46:15 UTC
It builds fine in a mock here.

Comment 11 John Mahowald 2006-09-30 21:35:56 UTC
rpmlint of newsx:
E: newsx non-standard-dir-perm /var/spool/news/inhosts 0770

+ source matches upstream
+ proper use of macros
+ license (GPL)
+ good buildroot
+ %clean section
+ smp flags
+ all needed BuildRequires

APPROVED

Comment 12 Dominik 'Rathann' Mierzejewski 2006-10-01 12:36:21 UTC
Darn, you *were* right after all, it failed on the builders just the way you
described it. And yet 2 other people were unable to reproduce it... incredible.
Anyway, I "fixed" the build just like you told me to, imported and built for
devel. FC-5 branch requested. Thanks for the review!

Comment 13 John Mahowald 2006-10-01 15:29:30 UTC
You are welcome.

Odd that you could not reproduce. I did mock build mine.


Note You need to log in before you can comment on or make changes to this bug.