Bug 1772392

Created attachment 1636094 [details]
a detailed log of packagemanifest of redhat-operators-art and redhat-operators

Description of problem:
ASB/TSB operators failed to upgrade from 4.2 to 4.3 for no "olm.skipRange" or "replace" field in CSVs.

Version-Release number of selected component (if applicable):
4.3.0-0.nightly-2019-11-13-233341

How reproducible:
Always

Steps to Reproduce:
1. change app registry to redhat-operators-art
2. install tsb operators with manifest from redhat-operators-art, choose channel "4.2", the csv version is "openshifttemplateservicebrokeroperator.4.2.5-201911121709"
3. upgrade cluster from 4.2.5 to 4.3.0-0.nightly-2019-11-13-233341
4. change tsb operator subscription channel to "4.3"

Actual results:
the tsb operator subscription channel changed to "4.3", but the csv is still openshifttemplateservicebrokeroperator.4.2.5-201911121709 


Expected results:
the tsb operator subscription channel changed to "4.3", and the csv should be openshifttemplateservicebrokeroperator.openshiftansibleservicebroker.4.3.0-201911121117

Additional info:
checked csv of tsb, there is no "olm.skipRange" for channel "4.2"and "4.3",but "4.1" do have this field. Check with app registry:redhat-operators, there is also no "olm.skipRange" for channel "4.2" but "4.1" have. Attached a detailed log in the attachment.

$oc get packagemanifest openshifttemplateservicebroker -n openshift-marketplace -o yaml
apiVersion: packages.operators.coreos.com/v1
kind: PackageManifest
metadata:
  creationTimestamp: "2019-11-14T02:16:27Z"
  labels:
    catalog: qe-app-registry
    catalog-namespace: openshift-marketplace
    olm-visibility: hidden
    openshift-marketplace: "true"
    opsrc-datastore: "true"
    opsrc-owner-name: qe-app-registry
    opsrc-owner-namespace: openshift-marketplace
    provider: Red Hat, Inc.
    provider-url: ""
  name: openshifttemplateservicebroker
  namespace: openshift-marketplace
  selfLink: /apis/packages.operators.coreos.com/v1/namespaces/openshift-marketplace/packagemanifests/openshifttemplateservicebroker
spec: {}
status:
  catalogSource: qe-app-registry
  catalogSourceDisplayName: ""
  catalogSourceNamespace: openshift-marketplace
  catalogSourcePublisher: ""
  channels:
  - currentCSV: openshifttemplateservicebrokeroperator.4.2.5-201911121709
    currentCSVDesc:
      annotations:
        alm-examples: '[{"apiVersion":"osb.openshift.io/v1","kind":"TemplateServiceBroker","metadata":{"name":"template-service-broker","namespace":"template-service-broker"},"spec":{}}]'
        capabilities: Seamless Upgrades
        containerImage: image-registry.openshift-image-registry.svc:5000/openshift/ose-template-service-broker@sha256:4b33168a9d5963c83f678f1efc0291560ff2689ee3b3f4a1b72d10d02f89a666
        description: OpenShift Template Service Broker is an implementation of the
          [Open Service Broker API](https://github.com/openservicebrokerapi/servicebroker)
      apiservicedefinitions: {}
      customresourcedefinitions:
        owned:
        - description: An Open Service Broker supporting management of OpenShift templates.
          displayName: Template Service Broker
          kind: TemplateServiceBroker
          name: templateservicebrokers.osb.openshift.io
          version: v1
      description: |
        The OpenShift Template Service Broker implements the [Open Service Broker
        API](https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md)
        endpoints:
        - *Catalog*: returns a list of available templates as OSB API
          *Service* objects (the templates are read from one or more
          namespaces configured in the master config).
        - *Provision*: provision a given template (referred by its UID) into a
          namespace.  Under the covers, this creates a non-namespaced
          **BrokerTemplateInstance** object for the template service broker to
          store state associated with the the instantiation, as well as the
          **Secret** and **TemplateInstance** objects which are picked up by
          the **TemplateInstance** controller.  *Provision* is an asynchronous
          operation: it may return before provisioning is completed, and the
          provision status can (must) be recovered via the *Last Operation*
          endpoint (see below).
        - *Bind*: for a given template, return "credentials" exposed in any
          created ConfigMap, Secret, Service or Route object (see
          ExposeAnnotationPrefix and Base64ExposeAnnotationPrefix
          documentation).  The *Bind* call records the fact that it took
          place in the appropriate **BrokerTemplateInstance** object.
        - *Unbind*: this simply removes the metadata previously placed in the
          **BrokerTemplateInstance** object by a *Bind* call.
        - *Deprovision*: removes the objects created by the *Provision* call.
          The garbage collector removes all additional objects created by the
          **TemplateInstance** controller, hopefully transitively, as
          documented above.
        - *Last Operation*: returns the status of the previously run
          asynchronous operation.  In the template service broker, *Provision*
          is the only asynchronous operation.
      displayName: OpenShift Template Service Broker Operator
      installModes:
      - supported: true
        type: OwnNamespace
      - supported: true
        type: SingleNamespace
      - supported: false
        type: MultiNamespace
      - supported: false
        type: AllNamespaces
      provider:
        name: Red Hat, Inc.
      version: 4.2.5-201911121709
    name: "4.2"
  - currentCSV: openshifttemplateservicebrokeroperator.4.3.0-201911081022
    currentCSVDesc:
      annotations:
        alm-examples: '[{"apiVersion":"osb.openshift.io/v1","kind":"TemplateServiceBroker","metadata":{"name":"template-service-broker","namespace":"template-service-broker"},"spec":{}}]'
        capabilities: Seamless Upgrades
        containerImage: image-registry.openshift-image-registry.svc:5000/openshift/ose-template-service-broker@sha256:e79b20346de0faa6e807725ed2989de9aa3d2401a97b77c256bb8359ece316d7
        description: OpenShift Template Service Broker is an implementation of the
          [Open Service Broker API](https://github.com/openservicebrokerapi/servicebroker)
      apiservicedefinitions: {}
      customresourcedefinitions:
        owned:
        - description: An Open Service Broker supporting management of OpenShift templates.
          displayName: Template Service Broker
          kind: TemplateServiceBroker
          name: templateservicebrokers.osb.openshift.io
          version: v1
      description: |
        The OpenShift Template Service Broker implements the [Open Service Broker
        API](https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md)
        endpoints:
        - *Catalog*: returns a list of available templates as OSB API
          *Service* objects (the templates are read from one or more
          namespaces configured in the master config).
        - *Provision*: provision a given template (referred by its UID) into a
          namespace.  Under the covers, this creates a non-namespaced
          **BrokerTemplateInstance** object for the template service broker to
          store state associated with the the instantiation, as well as the
          **Secret** and **TemplateInstance** objects which are picked up by
          the **TemplateInstance** controller.  *Provision* is an asynchronous
          operation: it may return before provisioning is completed, and the
          provision status can (must) be recovered via the *Last Operation*
          endpoint (see below).
        - *Bind*: for a given template, return "credentials" exposed in any
          created ConfigMap, Secret, Service or Route object (see
          ExposeAnnotationPrefix and Base64ExposeAnnotationPrefix
          documentation).  The *Bind* call records the fact that it took
          place in the appropriate **BrokerTemplateInstance** object.
        - *Unbind*: this simply removes the metadata previously placed in the
          **BrokerTemplateInstance** object by a *Bind* call.
        - *Deprovision*: removes the objects created by the *Provision* call.
          The garbage collector removes all additional objects created by the
          **TemplateInstance** controller, hopefully transitively, as
          documented above.
        - *Last Operation*: returns the status of the previously run
          asynchronous operation.  In the template service broker, *Provision*
          is the only asynchronous operation.
      displayName: OpenShift Template Service Broker Operator
      installModes:
      - supported: true
        type: OwnNamespace
      - supported: true
        type: SingleNamespace
      - supported: false
        type: MultiNamespace
      - supported: false
        type: AllNamespaces
      provider:
        name: Red Hat, Inc.
      version: 4.3.0-201911081022
    name: "4.3"
  - currentCSV: openshifttemplateservicebrokeroperator.4.1.24-201911120311
    currentCSVDesc:
      annotations:
        alm-examples: '[{"apiVersion":"osb.openshift.io/v1","kind":"TemplateServiceBroker","metadata":{"name":"template-service-broker","namespace":"template-service-broker"},"spec":{}}]'
        capabilities: Seamless Upgrades
        containerImage: image-registry.openshift-image-registry.svc:5000/openshift/ose-template-service-broker@sha256:b76eaf9a9a73ed95f3c596e1f3723c9ebd4fa9648a4958099c39ac2008058673
        description: OpenShift Template Service Broker is an implementation of the
          [Open Service Broker API](https://github.com/openservicebrokerapi/servicebroker)
        olm.skipRange: '>=4.1.0 <4.1.24-201911120311'
      apiservicedefinitions: {}