Bug 1772655 - [ovn] implement reject for empty services
Summary: [ovn] implement reject for empty services
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.3.0
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: ---
: 4.5.0
Assignee: Tim Rozet
QA Contact: Anurag saxena
URL:
Whiteboard:
Depends On: 1795790 1805651
Blocks: 1810567 1810570
TreeView+ depends on / blocked
 
Reported: 2019-11-14 20:00 UTC by Dan Williams
Modified: 2020-07-13 17:12 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1810567 (view as bug list)
Environment:
Last Closed: 2020-07-13 17:12:14 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github ovn-org ovn-kubernetes pull 1096 0 None closed Fixes empty services, load balancer creation in OVN 2020-06-23 08:14:54 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:12:31 UTC

Description Dan Williams 2019-11-14 20:00:04 UTC
https://github.com/ovn-org/ovn-kubernetes/issues/928

Kubernetes expects services without endpoints to reject connections rather than blackhole them. ovn-kubernetes currently removes service VIPs from the node switch service load balancer when they have no endpoints, which blackholes the connections.

Instead, a node switch ACL should be created to reject traffic to that Service VIP which will either RST for TCP or ICMP unreach for UDP.

Comment 2 Dan Williams 2020-01-13 15:56:01 UTC
Mark's patch is here. IIRC it is complete but needed some functional testing to push it over the line:  https://github.com/putnopvut/ovn-kubernetes/tree/acl_reject

Comment 3 Dan Williams 2020-01-13 15:56:59 UTC
The PR is IPv4 only though; needs some small updates for v6.

Comment 4 Tim Rozet 2020-01-21 15:31:14 UTC
Just making sure that Mark has no intention of finishing his patch and taking this bug before I take it. Can you please confirm Mark?

Comment 5 Tim Rozet 2020-01-23 15:05:47 UTC
After talking with Mark I'll go ahead and take this.

Comment 6 Dan Williams 2020-02-28 14:34:12 UTC
https://github.com/ovn-org/ovn-kubernetes/pull/1096

Comment 7 Ben Bennett 2020-03-05 14:09:09 UTC
This ovn bug should not block 4.4.  We will keep working on it and backport to 4.4.z and 4.3.z.  I will make clones to track.

Comment 8 Tim Rozet 2020-04-14 13:56:11 UTC
Included with https://github.com/openshift/ovn-kubernetes/pull/134

Comment 14 errata-xmlrpc 2020-07-13 17:12:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.