Bug 177275 - Review Request: perl-AnyData: Easy access to data in many formats
Review Request: perl-AnyData: Easy access to data in many formats
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Eric Tanguy
David Lawrence
:
Depends On:
Blocks: FE-ACCEPT 177276
  Show dependency treegraph
 
Reported: 2006-01-08 13:29 EST by Tom "spot" Callaway
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-04-03 17:25:16 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Tom "spot" Callaway 2006-01-08 13:29:10 EST
Spec Name or Url: http://www.auroralinux.org/people/spot/review/perl-AnyData.spec
SRPM Name or Url: http://www.auroralinux.org/people/spot/review/perl-AnyData-0.10-1.src.rpm
Description: 

The AnyData modules provide simple and uniform access to data from
many sources -- perl arrays, local files, remote files retrievable via
http or ftp -- and in many formats including flat files (CSV, Fixed
Length, Tab Delimited, etc), standard format files (Web Logs,
Passwd files, etc.),  structured files (XML, HTML Tables) and binary
files with parseable headers (mp3s, jpgs, pngs, etc).

There are two separate modules, each providing a different interface:
AnyData.pm provides a simple tied hash interface and DBD::AnyData
provides a DBI/SQL interface.  You can use either or both depending on
your needs.

This package is a new BuildRequires for perl-Class-DBI-AbstractSearch.
Comment 1 Eric Tanguy 2006-01-25 11:59:11 EST
Review for release 1:
* RPM name is OK
* Source AnyData-0.10.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of perl-AnyData looks OK
* File list of perl-AnyData looks OK

Needs work:
* BuildRequires: perl should not be included
  (wiki: PackagingGuidelines#Exceptions)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* The package should contain the text of the license
  (wiki: PackageReviewGuidelines)
Comment 2 Paul Howarth 2006-02-02 12:40:46 EST
(In reply to comment #1)
> Review for release 1:
> * RPM name is OK
> * Source AnyData-0.10.tar.gz is the same as upstream
> * Builds fine in mock
> * rpmlint of perl-AnyData looks OK
> * File list of perl-AnyData looks OK
> 
> Needs work:
> * BuildRequires: perl should not be included
>   (wiki: PackagingGuidelines#Exceptions)
> * Missing SMP flags. If it doesn't build with it, please add a comment
>   (wiki: PackagingGuidelines#parallelmake)

Agreed.

> * The package should contain the text of the license
>   (wiki: PackageReviewGuidelines)

This only applies of the upstream tarball includes the license text, which this
one doesn't.

Comment 4 Eric Tanguy 2006-04-03 16:24:13 EDT
Review for release 2:
* RPM name is OK
* Source AnyData-0.10.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of perl-AnyData looks OK
* File list of perl-AnyData looks OK
APPROVED

Note You need to log in before you can comment on or make changes to this bug.