Bug 1772873 - ovirt_host ansible module completely lacks the portal parameter initializing IscsiDetails struct
Summary: ovirt_host ansible module completely lacks the portal parameter initializing ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-ansible-collection
Version: 4.4.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ovirt-4.4.3
: ---
Assignee: Martin Necas
QA Contact: Pavol Brilla
URL:
Whiteboard:
Depends On:
Blocks: 1768969
TreeView+ depends on / blocked
 
Reported: 2019-11-15 12:23 UTC by Sandro Bonazzola
Modified: 2020-11-24 00:05 UTC (History)
9 users (show)

Fixed In Version: ovirt-ansible-collection-1.2.0-0.1
Doc Type: No Doc Update
Doc Text:
Clone Of: 1768969
Environment:
Last Closed: 2020-11-02 11:33:55 UTC
oVirt Team: Infra
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github ansible ansible pull 66750 0 None closed ovirt_host: add iscsi portal 2021-02-14 07:08:26 UTC

Description Sandro Bonazzola 2019-11-15 12:23:34 UTC
+++ This bug was initially created as a clone of Bug #1768969 +++

cloned to Ansible component for handling the ovirt_host ansible module part

--- Additional comment from Simone Tiraboschi on 2019-11-06 08:12:25 UTC ---

Please notice that for historical reason the Target Portal Group Tag (TGPT) attribute is called portal on REST API and the python SDK:
http://ovirt.github.io/ovirt-engine-sdk/master/types.m.html#ovirtsdk4.types.IscsiDetails


Then notice that ovirt_host ansible module completely lacks the portal parameter initializing IscsiDetails struct:
https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/ovirt/ovirt_host.py#L596

So we need to fix that one first.

Comment 1 Martin Perina 2019-11-15 17:48:20 UTC
Just be aware that in Ansible term adding parameters is an RFE, which mean this cannot be fixed earlier than in 2.10. So once fixed in master I suggest to ship hosted-engine-setup role with this updated module.

Comment 2 Sandro Bonazzola 2020-03-30 13:36:02 UTC
(In reply to Martin Perina from comment #1)
> Just be aware that in Ansible term adding parameters is an RFE, which mean
> this cannot be fixed earlier than in 2.10. So once fixed in master I suggest
> to ship hosted-engine-setup role with this updated module.

assuming this is in modified because it has been included in ansible 2.10.
Can you send PR to hosted-engine-role for shipping the updated module?

Comment 3 Martin Necas 2020-10-06 05:37:30 UTC
The PR was moved to collection same as hosted-engine role so now you can use it inside the role.


Note You need to log in before you can comment on or make changes to this bug.