Bug 1772898 - Make mask_password case insensitive, and add new patterns
Summary: Make mask_password case insensitive, and add new patterns
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: python-oslo-utils
Version: 16.0 (Train)
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: z1
: 16.0 (Train on RHEL 8.1)
Assignee: Hervé Beraud
QA Contact: pkomarov
URL:
Whiteboard:
Depends On:
Blocks: 1826667
TreeView+ depends on / blocked
 
Reported: 2019-11-15 14:04 UTC by Hervé Beraud
Modified: 2020-04-22 09:37 UTC (History)
4 users (show)

Fixed In Version: python-oslo-utils-3.41.3-1.el8ost
Doc Type: Bug Fix
Doc Text:
Previously, password-masking patterns were not functioning correctly in oslo.utils. As a result, service logs sometimes contained plan text passwords. With this update, the password-masking patterns function correctly and password leaks in log files do not occur.
Clone Of:
: 1826667 (view as bug list)
Environment:
Last Closed: 2020-03-03 09:50:03 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenStack gerrit 692968 0 'None' MERGED Make mask_password case insensitive, and add new patterns 2020-04-22 09:34:01 UTC
OpenStack gerrit 694025 0 'None' MERGED oslo.utils: release train 3.41.3 2020-04-22 09:34:01 UTC
Red Hat Product Errata RHBA-2020:0657 0 None None None 2020-03-03 09:50:19 UTC

Description Hervé Beraud 2019-11-15 14:04:15 UTC
It appears that Mistral service logs everything, and doesn't use yet the mask_password (nor mask_dict_password) method. In order to ensure all is properly masked, we have to add some new patterns, and make it case insensitive in order to simplify and avoid duplicated entries. 

Rebase python-oslo-utils to 3.41.4 to pull the fix in current version

The version 3.41.4 will fix a CVE where passwords leaks in logs.

This CVE is fixed by cae9aa72377713c2fc93b5cf3fad05b873a55d6d

Comment 4 Hervé Beraud 2019-11-15 14:39:08 UTC
Errata:

s/3.41.4/3.41.3/gi

Rebase python-oslo-utils to 3.41.3 to pull the fix in current version

The version 3.41.3 will fix a CVE where logs leaks passwords.

Comment 7 Hervé Beraud 2019-11-15 15:27:04 UTC
Will be fixed in version python-oslo-utils-3.41.3-1.el8ost

https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=24730585

Comment 13 pkomarov 2020-02-18 11:47:24 UTC
Verified , 


[stack@undercloud-0 ~]$ rpm -qa|grep python3-oslo-utils
python3-oslo-utils-3.41.4-0.20200113095842.39870f6.el8ost.noarch

[root@undercloud-0 mistral]# pwd
/var/log/containers/mistral
[root@undercloud-0 mistral]# grep -q passphrase *
[root@undercloud-0 mistral]# echo $?
0

Comment 14 Alex McLeod 2020-02-19 12:39:28 UTC
If this bug requires doc text for errata release, please set the 'Doc Type' and provide draft text according to the template in the 'Doc Text' field. The documentation team will review, edit, and approve the text.

If this bug does not require doc text, please set the 'requires_doc_text' flag to '-'.

Comment 16 errata-xmlrpc 2020-03-03 09:50:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0657


Note You need to log in before you can comment on or make changes to this bug.