Bug 1774098 - Review Request: gitfs - FUSE userland filesytem for git
Summary: Review Request: gitfs - FUSE userland filesytem for git
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2019-11-19 14:48 UTC by Vlad Temian
Modified: 2021-01-10 00:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-01-10 00:45:28 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Vlad Temian 2019-11-19 14:48:01 UTC
Spec URL: https://github.com/presslabs/gitfs/releases/download/0.5.2/gitfs.spec
SRPM URL: https://github.com/presslabs/gitfs/releases/download/0.5.2/gitfs-0.5.2-1.14.src.rpm
Description: gitfs is a FUSE file system that fully integrates with git. You can mount a remote repository's branch locally, and any subsequent changes made to the files will be automatically committed to the remote.
Fedora Account System Username: vtemian

Comment 1 Robert-André Mauchin 🐧 2019-12-10 18:00:03 UTC
 - License is not a valid shourthand, see list here: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses

License:        ASL 2.0

 - Release start at 1

Release:        1

 - Group: is not used in Fedora

 - BR should indicate the Python3 version, unversioned is forbidden:

BuildRequires:  python3-devel
BuildRequires:  python3-setuptools
Requires:       python3-atomiclong
Requires:       python3-fusepy 
Requires:       python3-pygit2
Requires:       python3-raven
Requires:       python3-pycparser

 - BuildRoot: is not used in Fedora

 - You should remove preexisting egginfo

rm -rf gitfs.egg-info/

 - python setup.py build β†’ %py3_build

 - python setup.py install --prefix=%{_prefix} --root=%{buildroot}  β†’ %py3_install

 - %{buildroot}/var/lib/gitfs β†’ %{buildroot}%{_sharedstatedir}/gitfs

 - Not needed: %defattr(-,root,root,-)

 - Should be python3 and globbing the entirety of %{python_sitelib}/ is forbidden, be more specific instead:

%{python_sitelib}/gitfs/

- %changelog entries are not valid:

* Tue Nov 19 2019 Vlad Temian <vladtemian> - 0.5.1-1

 Please read the Guidelines and specifically the Python ones: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/

Comment 2 Package Review 2020-12-10 00:45:24 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 3 Package Review 2021-01-10 00:45:28 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.