Bug 1776142 - Review Request: rust-gethostname - Gethostname for all platforms
Summary: Review Request: rust-gethostname - Gethostname for all platforms
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1779966
TreeView+ depends on / blocked
 
Reported: 2019-11-25 08:32 UTC by Artem
Modified: 2019-12-12 14:26 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-12-12 14:26:08 UTC
Type: Bug
Embargoed:
eclipseo: fedora-review+

Attachments (Terms of Use)

Description Artem 2019-11-25 08:32:42 UTC 
Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/rust-crates/fedora-rawhide-x86_64/01117878-rust-gethostname/rust-gethostname.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/rust-crates/fedora-rawhide-x86_64/01117878-rust-gethostname/rust-gethostname-0.2.0-1.fc32.src.rpm

Description:
Gethostname for all platforms.

Fedora Account System Username: atim
Comment 1 Igor Raits 2019-12-07 12:35:42 UTC 
> # test tests::gethostname_matches_system_hostname ... FAILED

No link to the upstream bugreport.

> # Initial patched metadata

No information what has been patched and why + links to the upstream.
Comment 2 Artem 2019-12-07 20:49:03 UTC 
https://copr-be.cloud.fedoraproject.org/results/atim/rust-crates/fedora-rawhide-x86_64/01125967-rust-gethostname/rust-gethostname.spec

https://copr-be.cloud.fedoraproject.org/results/atim/rust-crates/fedora-rawhide-x86_64/01125967-rust-gethostname/rust-gethostname-0.2.0-2.fc32.src.rpm
Comment 3 Artem 2019-12-11 17:13:58 UTC 
✅ Now tests passed.

https://copr-be.cloud.fedoraproject.org/results/atim/rust-crates/fedora-rawhide-x86_64/01128128-rust-gethostname/rust-gethostname.spec

https://copr-be.cloud.fedoraproject.org/results/atim/rust-crates/fedora-rawhide-x86_64/01128128-rust-gethostname/rust-gethostname-0.2.0-3.fc32.src.rpm
Comment 4 Robert-André Mauchin 🐧 2019-12-11 20:39:54 UTC 
 - Detail what you've changed:

# Initial patched metadata
# * Remove Windows-only dependencies
# * Bump pretty_assertions to 0.6.1 https://github.com/lunaryorn/gethostname.rs/commit/4b50f071448ea153a5222199e562d5454baab127
Patch0:         gethostname-fix-metadata.diff


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.
Comment 5 Gwyn Ciesla 2019-12-11 21:32:00 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gethostname
Note You need to log in before you can comment on or make changes to this bug.