Created attachment 1639773 [details] Proposal fix # glfsheal nosuchvolume Volume nosuchvolume does not exist # glfsheal --oops Segmentation fault (core dumped)
Dmitry, glfsheal is not supposed to be invoked directly. You need to use the `gluster volume heal $VOLNAME` CLI only. That said, the fix seems to be a good check for gfapi programs that call "glfs_new($junk_volname)" causing it to crash. Can you send the attachment as a patch for review on gerrit? The work-flow is detailed at https://docs.gluster.org/en/latest/Developer-guide/Simplified-Development-Workflow/. Let me know if you need any help.
REVIEW: https://review.gluster.org/23806 (core: avoid NULL pointer dereference) posted (#1) for review on master by None
(In reply to Ravishankar N from comment #1) > Dmitry, glfsheal is not supposed to be invoked directly. If so, shouldn't it be installed to (and invoked from) ${prefix}/libexec rather than ${prefix}/sbin?
(In reply to Dmitry Antipov from comment #3) > If so, shouldn't it be installed to (and invoked from) ${prefix}/libexec > rather than ${prefix}/sbin? Yes, correct. Feel free to send a patch if you would like to.
REVIEW: https://review.gluster.org/23806 (core: avoid NULL pointer dereference) merged (#3) on master by Xavi Hernandez
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days