+++ This bug was initially created as a clone of Bug #1774419 +++

Description of problem:
When creating cr SriovNetworkNodePolicy with "resourceName: intel-rhel".  the device-plugin pod creashed with error: 

oc logs sriov-device-plugin-klb2t
I1120 09:36:40.274970      20 manager.go:70] Using Kubelet Plugin Registry Mode
I1120 09:36:40.275183      20 main.go:44] resource manager reading configs
I1120 09:36:40.275746      20 manager.go:98] ResourceList: [{ResourceName:intelnetdevice-rhel IsRdma:false Selectors:{Vendors:[8086] Devices:[] Drivers:[iavf mlx5_core i40evf ixgbevf] PfNames:[p1p1] LinkTypes:[]}}]
E1120 09:36:40.275876      20 manager.go:161] resource name "intelnetdevice-rhel" contains invalid characters
F1120 09:36:40.275901      20 main.go:57] Exiting.. one or more invalid configuration(s) given

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Assume the sriov operator is installed
2. Create one CR with:
apiVersion: sriovnetwork.openshift.io/v1
kind: SriovNetworkNodePolicy
metadata:
  name: intel-netdevice-rhel
  namespace: openshift-sriov-network-operator
spec:
  deviceType: netdevice
  mtu: 1500
  nicSelector:
    pfNames:
      - p1p1
    rootDevices:
      - '0000:3b:00.0'
    vendor: '8086'
  nodeSelector:
    feature.node.kubernetes.io/sriov-capable-rhel: 'true'
  numVfs: 5
  priority: 99
  resourceName: intel-rhel
3. oc get pod
4. 

Actual results:

oc logs sriov-device-plugin-klb2t
I1120 09:36:40.274970      20 manager.go:70] Using Kubelet Plugin Registry Mode
I1120 09:36:40.275183      20 main.go:44] resource manager reading configs
I1120 09:36:40.275746      20 manager.go:98] ResourceList: [{ResourceName:intelnetdevice-rhel IsRdma:false Selectors:{Vendors:[8086] Devices:[] Drivers:[iavf mlx5_core i40evf ixgbevf] PfNames:[p1p1] LinkTypes:[]}}]
E1120 09:36:40.275876      20 manager.go:161] resource name "intelnetdevice-rhel" contains invalid characters
F1120 09:36:40.275901      20 main.go:57] Exiting.. one or more invalid configuration(s) given

Expected results:

Webhook should add validation for resourceName.

Additional info:

--- Additional comment from Peng Liu on 2019-11-25 09:32:59 UTC ---

The sriov-network-device-plugin only allows the resourceNames which follow '^[a-zA-Z0-9-]+$'. I guess the intention is to follow rfc952. However, in rfc952, '-' is a valid character. The sriov-network-device-plugin code may also need to be fixed.