Bug 1776943 (CVE-2019-14905) - CVE-2019-14905 Ansible: malicious code could craft filename in nxos_file_copy module
Summary: CVE-2019-14905 Ansible: malicious code could craft filename in nxos_file_copy...
Keywords:
Status: VERIFIED
Alias: CVE-2019-14905
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Red Hat Product Security
QA Contact:
URL:
Whiteboard:
Depends On: 1777277 1777278 1777279 1777280 1777691 1777692 1777693 1783064 1785152 1783065
Blocks: 1760304
TreeView+ depends on / blocked
 
Reported: 2019-11-26 15:49 UTC by Borja Tarraso
Modified: 2020-01-20 23:57 UTC (History)
39 users (show)

Fixed In Version: ansible-engine 2.9.4, ansible-engine 2.8.8, ansible-engine 2.7.16
Doc Type: If docs needed, set a value
Doc Text:
A vulnerability in Ansible's nxos_file_copy module can be used to copy files to a flash or bootflash on NXOS devices. Malicious code could craft the filename parameter to perform OS command injections. This could result in a loss of confidentiality of the system among other issues.
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)

Description Borja Tarraso 2019-11-26 15:49:36 UTC
A vulnerability has been found in nxos_file_copy from Ansible module. Filenames are used to perform actions to copy files to a flash or bootflash on NXOS devices. However, nxos_file_copy takes remote_file parameter which is used for destination. Malicious code could crafts the filename parameter to take advantage by performing an OS command injection.

Comment 1 Borja Tarraso 2019-11-26 15:49:38 UTC
Acknowledgments:

Name: Abhijeet Kasurde (Red Hat)

Comment 4 Borja Tarraso 2019-11-28 05:49:51 UTC
Created ansible tracking bugs for this issue:

Affects: epel-all [bug 1777693]
Affects: fedora-all [bug 1777692]
Affects: openstack-rdo [bug 1777691]

Comment 7 Abhijeet Kasurde 2019-12-02 07:22:41 UTC
Adding Ganesh Nalawade who is fixing this issue.

Comment 13 Hardik Vyas 2019-12-19 09:41:07 UTC
Gluster and Ceph no more maintains ansible, and the plan is to use from ansible repository. But we still ship ansible separately in ceph ubuntu.

Comment 16 bulletins-coordon 2020-01-02 11:40:22 UTC
Hi Red Hat Team.

Happy new year ^_^

Could you please recheck on 2.9.2 ?

We think Ansible 2.9.2 is also vulnerable. We checked the source files of 2.9.2 ; and the related commit [1] was not embedded.

Ansible 2.8.8 and 2.7.16 are not released yet [2] so we can't check.

Regards, 

Wilfried
CERT Orange Cyberdefense

[1] https://github.com/ansible/ansible/pull/65846/commits/254d8032520b712a27eef0f907e911545d593604
[2] https://github.com/ansible/ansible/releases

Comment 18 Borja Tarraso 2020-01-02 13:20:28 UTC
Hi Wilfried,

Many thanks for the report. Indeed you are right, 2.9.2 it is still vulnerable. The fix was getting ready to fix on the 2.9.2 release. However, for some reason the PR was blocked. I updated and corrected that information and contacted the engineer if there is any estimations and technicalities regarding the fix.

Regards,
Borja

Comment 19 Nick Tait 2020-01-08 20:13:03 UTC
Statement:

Ansible Engine 2.7.15, 2.8.7, and 2.9.2 as well as previous versions are affected.

Red Hat Gluster Storage 3 and Red Hat Ceph Storage 3 no longer maintain their own version of Ansible. Therefore this fix will be consumed directly from core Ansible.

Comment 20 Nick Tait 2020-01-08 20:13:06 UTC
Mitigation:

There is no mitigation for this issue, the flaw can only be resolved by applying updates.


Note You need to log in before you can comment on or make changes to this bug.