RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1777201 - [machines] The message needs correction when try to delete network interface when VM is running
Summary: [machines] The message needs correction when try to delete network interface ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: cockpit-appstream
Version: 8.2
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: 8.2
Assignee: Simon Kobyda
QA Contact: Xianghua Chen
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-11-27 06:32 UTC by Xianghua Chen
Modified: 2020-04-28 15:43 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-04-28 15:43:05 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2020:1639 0 None None None 2020-04-28 15:43:19 UTC

Description Xianghua Chen 2019-11-27 06:32:46 UTC 
Description of problem:
The message needs correction when try to delete network interface when VM is running

Version-Release number of selected component (if applicable):
cockpit-machines-206-1.el8.noarch
libvirt-dbus-1.2.0-3.module+el8.1.0+4066+0f1aadab.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Open the Networks page of a running VM
2. Move the mouse on "Delete" at the end of one network interface.

Actual results:
The delete button is gray and there is a message saying:
The VM needs to be running or shut off to detach this device


Expected results:
The message should be:
The VM needs to be shut off to detach this device.

Additional info:
Comment 1 Martin Pitt 2019-11-27 07:56:58 UTC 
Agreed, this was apparently a copy&paste error from pkg/machines/components/vmDisksTab.jsx (where you really can detach a disk while the VM is running). 

Simon, the second line in pkg/machines/components/vmnetworktab.jsx is trivial to fix:

     disabled={vm.state != 'shut off'}
     overlayText={_("The VM needs to be running or shut off to detach this device")}
     deleteHandler={() => detachIface(network.mac, vm.connectionName, vm.id, vm.state === "running", dispatch)} />;


But please have a look at the third line. The comparison against "running" smells wrong, as the button would be disabled in that state. So that argument should always be `false`.
Comment 2 Simon Kobyda 2019-11-28 14:04:09 UTC 
Right. The problem is the first line, where the button get's disabled if VM is not shutoff (it should be enabled if VM is also runnin)
The text of message is correct.
And the third line is just a flag, which tells us that vm is running, and thereforce apart from an offline VM XML we also have to update live VM XML when detaching a VM. So all of the infrastructure for detaching from running VM was setup, but condition which would disable delete button had a bug :)
Comment 3 Martin Pitt 2019-11-29 14:04:20 UTC 
https://github.com/cockpit-project/cockpit/pull/13212
Comment 6 Xianghua Chen 2019-12-23 06:36:54 UTC 
Verified with packages:
cockpit-machines-209-1.el8.noarch
libvirt-dbus-1.2.0-3.module+el8.1.0+4066+0f1aadab.x86_64

Steps:
1. Open the Networks page of a running VM
2. Click "Delete" at the end of one network interface.

The "Delete" button is enabled for running vm and there will be a dialog prompt when clicking delete, and the network interface can be deleted after confirmation.
So verified.
Comment 8 errata-xmlrpc 2020-04-28 15:43:05 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1639
Note You need to log in before you can comment on or make changes to this bug.