Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1777513

Summary:	Not handled exceptions wrongly cause Kuryr Controller restart
Product:	OpenShift Container Platform	Reporter:	Maysa Macedo <mdemaced>
Component:	Networking	Assignee:	Maysa Macedo <mdemaced>
Networking sub component:	kuryr	QA Contact:	GenadiC <gcheresh>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	unspecified
Priority:	unspecified	CC:	gcheresh, itbrown, ltomasbo
Version:	4.4
Target Milestone:	---
Target Release:	4.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1777492	Environment:
Last Closed:	2020-01-23 11:14:45 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1777492
Bug Blocks:

Description Maysa Macedo 2019-11-27 16:42:53 UTC

+++ This bug was initially created as a clone of Bug #1777492 +++

Description of problem:

A few exceptions were not properly handled wrongly causing a Kuryr-Controller to restart: 
1) When retrying a deletion of a load balancer, the attempt to retrieve it could cause a NotFoundException, which is different than the currently exception being handled ResourceNotFound.
2) When the connection to Keystone is broken the controller is instantly marked as not healthy, when should at least retry a few times the connection before restarting. 

Version-Release number of selected component (if applicable):

OSP 15


How reproducible:


Steps to Reproduce:
1. Run OCP conformance tests 
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Itzik Brown 2019-12-11 14:32:05 UTC

Ran conformance tests.
The following failed:
[k8s.io] Kubelet when scheduling a busybox command that always fails in a pod should have an terminated reason [NodeConformance] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
[sig-cli] Kubectl client [k8s.io] Kubectl logs should be able to retrieve and filter logs  [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
[sig-network] DNS should provide /etc/hosts entries for the cluster [LinuxOnly] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
[sig-network] DNS should provide DNS for services  [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
[sig-network] DNS should provide DNS for the cluster  [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
[sig-storage] ConfigMap should be consumable from pods in volume [NodeConformance] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
[sig-storage] Projected downwardAPI should provide container's memory limit [NodeConformance] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]

No restart of the kuryr-controller

Using 4.3.0-0.nightly-2019-12-11-073659

Comment 3 Itzik Brown 2019-12-11 15:20:17 UTC

Ran conformance tests.                                                             
The following failed:                                                              
[k8s.io] Kubelet when scheduling a busybox command that always fails in a pod should have an terminated reason [NodeConformance] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
[sig-cli] Kubectl client [k8s.io] Kubectl logs should be able to retrieve and filter logs  [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
[sig-network] DNS should provide /etc/hosts entries for the cluster [LinuxOnly] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
[sig-network] DNS should provide DNS for services  [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
[sig-network] DNS should provide DNS for the cluster  [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
[sig-storage] ConfigMap should be consumable from pods in volume [NodeConformance] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
[sig-storage] Projected downwardAPI should provide container's memory limit [NodeConformance] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
                                                                                   
No restart of the kuryr-controller                                                 
                                                                                   
Using 4.3.0-0.nightly-2019-12-11-073659

Comment 5 errata-xmlrpc 2020-01-23 11:14:45 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0062