Hide Forgot
Description of problem: hammer setting content_default_http_proxy does not have validation for provided values Version-Release number of selected component (if applicable): @Satellite 6.7.0 snap 3,0 How reproducible: Always Steps to Reproduce: 1. Set settings as below: [root@hp-dl180-04 ~]# hammer settings set --name content_default_http_proxy --value xyz Setting [content_default_http_proxy] updated to [xyz]. [root@hp-dl180-04 ~]# hammer settings list |grep -i content_default_http_proxy content_default_http_proxy | Default http proxy | xyz | Default HTTP Proxy for syncing content [root@hp-dl180-04 ~]# 2. No check on UI for same setting , the value filed shows empty. Administer => Settings => Content => 'Default HTTP Proxy' Actual results: Any value could pass with '--value' Expected results: It should only set the setting if provided value is correct (i.e. already created proxy name) Additional info:
s/no/now 2. Now check on UI for same setting , the value filed shows empty. Administer => Settings => Content => 'Default HTTP Proxy'
I'd say that the problem is not on the hammer side. There is no validation on the server side if I use API call that is hidden under hammer command directly as well. I'd suggest to add a specific validation for content_default_http_proxy setting.
Created redmine issue https://projects.theforeman.org/issues/28386 from this bug
Moving this bug to POST for triage into Satellite 6 since the upstream issue https://projects.theforeman.org/issues/28386 has been resolved.
ON_QA Verified @Satellite 6.7.0 snap 7.0 Steps/Observation: - Unable to update invalid value - Able to pass '' for no_proxy - Able to update only specific/valid proxy ___________________________________________________________________________________________________________________ [root@qe-sat6-bm1 ~]# hammer settings set --name content_default_http_proxy --value xyz Could not update the setting: There is no such HTTP Proxy [root@qe-sat6-bm1 ~]# hammer settings set --name content_default_http_proxy --value '' Setting [content_default_http_proxy] updated to []. [root@qe-sat6-bm1 ~]# hammer settings list |grep -i content_default_http_proxy content_default_http_proxy | Default http proxy | | Default HTTP Proxy for syncing content [root@qe-sat6-bm1 ~]# hammer settings set --name content_default_http_proxy --value Proxy1 Setting [content_default_http_proxy] updated to [Proxy1]. [root@qe-sat6-bm1 ~]# hammer settings list |grep -i content_default_http_proxy content_default_http_proxy | Default http proxy | Proxy1 | Default HTTP Proxy for syncing content [root@qe-sat6-bm1 ~]# ___________________________________________________________________________________________________________________