Bug 1777805 - Improve logging during block size detections
Summary: Improve logging during block size detections
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-distribution
Classification: oVirt
Component: ioprocess
Version: 4.3.7
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ovirt-4.4.3
: ---
Assignee: Pavel Bar
QA Contact: Pavel Stehlik
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-11-28 11:07 UTC by Vojtech Juranek
Modified: 2020-10-14 00:32 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-10-13 10:33:05 UTC
oVirt Team: Storage
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 109395 0 None MERGED probe_block_size: Improve logging during block size detections 2020-11-02 12:44:07 UTC

Description Vojtech Juranek 2019-11-28 11:07:48 UTC
Description of problem:

When we detect block size, we create probe file and try to write possible block sizes there. After that, we remove the file. If it fails during this process, we get general exception like "Operation not permitted" (see e.g. BZ #1777726), but it's not clear, where exactly it failed (writing file, deleting file). It would be nice to provide more precise exception (e.g. "Failed to remove file $FILENAME: Operation not permitted"), as that admin can easily determine, where the problem is.

Comment 1 Nir Soffer 2020-02-01 21:38:46 UTC
The error message comes from ioprocess so it can be improved only there.

Comment 2 Nir Soffer 2020-05-26 11:47:47 UTC
Fixing the exception message is not enough since we delete the file after 
a successful probing, and we need to know about failing to delete a probe
file.

The simplest solution is to log detailed warnings in exp_probe_block_size()
open_probe() and close_probe(). These logs are written to iprocess stderr
and logged by vdsm. This should provide all the info we need to debug
issues.

If we want to pass a detailed error message for each of these unlikely
errors, we need to pass the GError** err from the API all down to
probe_open() use g_set_error().

I would start with logging warnings and spend our time on something
which bring more value to users.

Comment 3 Nir Soffer 2020-07-07 08:16:10 UTC
ioprocess with this fix was not released yet so we cannot 
test it yet.

Comment 4 Tal Nisan 2020-10-13 10:33:05 UTC
No need for verification, this is only logs addition


Note You need to log in before you can comment on or make changes to this bug.