From Bugzilla Helper: User-Agent: Mozilla/5.0 (compatible; Konqueror/3.5; Linux; X11; i686) KHTML/3.5.0 (like Gecko) Description of problem: When pressing the seek-to-end key ('>') twice, the second keypress causes an unnecessary, and very annoying, screen redraw. This is not very visible on the console, but very visible on konsole and gnome-terminal. Version-Release number of selected component (if applicable): less-394-1.fc4 How reproducible: Always Steps to Reproduce: 1. less /var/log/messages (or some text file) 2. type '>' 3. type '>' Actual Results: screen scrolls down and up quickly Expected Results: no flicker Additional info: LANG=en_US.UTF-8 Less worked well before the last update.
This seems to be related to bug 120916. The possible flickering of the terminal when pressing '>' multiple times I don't consider a bug. The flickering is very hardly noticable in konsole and gnome-terminal as far as I can see and it's needed to solve the bug, which allows less to display incorrect contents in a viewed file. When comparing flickering sometimes when pressing '>' multiple times with dislaying incorrect contents, I vote for flickering, sorry. If you have a different solution, feel free to reopen this bug and add it here.
The flickering is very noticable for me. As I'm a heavy less user, I'll look at producing a patch for only repainting if the file changed. Would that be acceptable?
Yes, feel free to send a patch here. I'll review it and if it's better than the fix for bug 120916, I'll be happy to apply it.
I have a patch.
Created attachment 123236 [details] fix for growing file without end-of-line at end, without unconditional repaint attached patch fixes the symptoms of bug 120916, without the unconditional repaint. after the seek it checks whether the end-of-file position is displayed, and if not, triggers a repaint. should be applied instead of less-382-fixline.patch.
Thanks, let me test it.
Looks good, applied in CVS.
The fix should appear in the tomorrow's rawhide.
Thank you for the quick response. I presume if it works out it'll go to FC4 as well?
Yes, I'll wait for a while to collect more fixes for less and then I'm going to release an update for FC3/FC4.
Closing RAWHIDE for now. Thanks for your patch and good work!
Bug is back. Redraws on unchanged files when pressing '>' repeatedly. Seen best (and most annoying) over ssh on a high-latency link.
less-394-5.fc6
I try to reproduce you r problem but I was unsuccesfull. Could you please try to reproduce this bug with the last version of less - less-394-9.fc7.
It reproduces. I tried in both Konsole and xterm. xterm ssh localhost less /var/log/messages press '>' repeatedly (or hold it down)
These problems are fixed in less-409-1.fr9 if there is any problem, please reopen this bug.