Spec Name or Url: http://rakta.wsg.mcgill.ca/fe/python-ctypes.spec SRPM Name or Url: http://rakta.wsg.mcgill.ca/fe/python-ctypes-0.9.6-1.src.rpm Description: ctypes is an advanced ffi (Foreign Function Interface) package for Python 2.3 and higher. ctypes allows to call functions exposed from dlls/shared libraries and has extensive facilities to create, access and manipulate simple and complicated C data types in Python - in other words: wrap libraries in pure Python. It is even possible to implement C callback functions in pure Python.
Hi Konstantin, I tried to download the SRPM but the machine doesn't fully respond. Running wget results in an indefinite wait. The machine is ping-able though, so its at least plugged in...
ping. (URLs are still inaccessible.)
My apologies! I've had to firewall off that machine according to the McGill policies. Here are the new locations: http://open.mcgill.ca/~icon/fe/python-ctypes-0.9.6-1.src.rpm http://open.mcgill.ca/~icon/fe/python-ctypes.spec
Thanks! The spec looks sane enough but there's a new upstream version. Do you want me to start reviewing this version or do you want to update first?
Konstantin- are you interested in updating to 0.9.9.6 (not sure is it a devevl version or stable)? http://prdownloads.sourceforge.net/ctypes/ctypes-0.9.9.6.tar.gz?download Toshio are you still interested in reviewing? This will be in python 2.5 so it might be nice to have it in Extras beforehand.
Paul: If you're volunteering to review if I say I'm too busy, I'll gladly let you take over :-) Otherwise, I can free up some weekend time to work on reviewing.
I'm happy to review this.
I'm currently seriously swamped at work. If someone wants to take over this one for me, I'd be more than happy to give up the reigns. :)
Hmmm Paul - do you want to take over packaging and I'll review? I'm only swamped with work, not seriously swamped :-)
http://people.redhat.com/pnasrat/extras/python-ctypes-0.9.9.6-1.src.rpm http://people.redhat.com/pnasrat/extras/python-ctypes.spec
Hey Paul -- your srpm is only 4096 bytes so there's something wrong.
Should be better now - sha1sum: f7a7efac9246e3195a6fdb39a10d84d5ed6ff6e6 python-ctypes-0.9.9.6-1.src.rpm
APPROVED SHA1SUM: f7a7efac9246e3195a6fdb39a10d84d5ed6ff6e6 python-ctypes-0.9.9.6-1.src.rpm 831a731eebf8950a3dd3eb4cc18dbde8c7a859f5 ctypes-0.9.9.6.tar.gz 20edf3c22969a49e6f0bdff9f321e303fa4928e7 python-ctypes.spec Informational: * Note that the CFLAGS=$RPM_OPT_FLAGS definition doesn't seem to do anything for this package. There's no harm in having it but the CFLAGS are actually being pulled in from python, not from the environment. Good: * All review guidelines passed. Highlights follow: * rpmlint has no output. * python-ctypes conforms to the naming guidelines. * License is MIT and included. * The spec file is clear and legible. * Source matches upstream. * Builds on x86_64. * Permissions set properly on all files. * No extraneous directories; no unowned files or directories. * Builds in mock. * Runs through its test suite on x86_64.
Nice job nasrat and icon. Sorry it took me so long to finish the review.
Please reassign this bug to the actual reviewer.
Package Change Request ====================== Package Name: python-ctypes New Branches: EL-5 Updated EPEL Owners: jkeating
cvs done.
Package Change Request ====================== Package Name: python-ctypes New Branches: el4 Owners: mdomsch mebrown
Git done (by process-git-requests).