Spec URL: https://leigh123linux.fedorapeople.org/pub/review/rubygem-linked-list/rubygem-linked-list.spec SRPM URL: https://leigh123linux.fedorapeople.org/pub/review/rubygem-linked-list/rubygem-linked-list-0.0.13-1.fc31.src.rpm Description: Ruby implementation of Doubly Linked List, following some Ruby idioms Fedora Account System Username: leigh123linux
* Execute the test suite - The test files are using name_test.rb convention, so you should change the test command to: ~~~ ruby -Ilib:. -e 'Dir.glob "test/**/*_test.rb", &method(:require)' ~~~ * Do not ship content of bin/* - If I am not mistaken, these files are useful just for development purposes and probably not really useful at all. I would suggest to either move them to -doc subpackage or remove them entirely. I think that even upstream should not ship them in the package.
Spec and srpm updated (In reply to Vít Ondruch from comment #1) > * Execute the test suite > - The test files are using name_test.rb convention, so you should change > the test command to: > > ~~~ > ruby -Ilib:. -e 'Dir.glob "test/**/*_test.rb", &method(:require)' > ~~~ > The tests fail + ruby -Ilib:. -e 'Dir.glob "test/**/*_test.rb", &method(:require)' Traceback (most recent call last): 6: from -e:1:in `<main>' 5: from -e:1:in `glob' 4: from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require' 3: from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require' 2: from /home/leigh/development/rpmbuild/BUILD/linked-list-0.0.13/usr/share/gems/gems/linked-list-0.0.13/test/conversions_test.rb:1:in `<top (required)>' 1: from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require' /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- test_helper (LoadError) error: Bad exit status from /var/tmp/rpm-tmp.bVoGik (%check) > * Do not ship content of bin/* > - If I am not mistaken, these files are useful just for development > purposes and probably not really useful at all. I would suggest to either > move them to -doc subpackage or remove them entirely. I think that even > upstream should not ship them in the package. bin/* moved to -doc subpackage
> /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- test_helper (LoadError) Possibly following command requiring test_helper works. ``` + ruby -Ilib:test -r test_helper.rb -e 'Dir.glob "test/**/*_test.rb", &method(:require)' ```
(In reply to Jun Aruga from comment #3) > > /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- test_helper (LoadError) > > Possibly following command requiring test_helper works. > > ``` > + ruby -Ilib:test -r test_helper.rb -e 'Dir.glob "test/**/*_test.rb", > &method(:require)' > ``` The `-r test_helper.rb` should not be necessary. Just adding `test` into load path via the `-I` option should be enough.
The tests still fail + pushd ./usr/share/gems/gems/linked-list-0.0.13 ~/rpmbuild/BUILD/linked-list-0.0.13/usr/share/gems/gems/linked-list-0.0.13 ~/rpmbuild/BUILD/linked-list-0.0.13 + sed -i '/bundler/ s/^/#/' Rakefile + ruby -Ilib:test -r test_helper.rb -e 'Dir.glob "test/**/*_test.rb",&method(:require)' Traceback (most recent call last): 3: from -e:1:in `<main>' 2: from -e:1:in `glob' 1: from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require' /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- test/conversions_test.rb (LoadError) error: Bad exit status from /var/tmp/rpm-tmp.CjdiAv (%check) + pushd ./usr/share/gems/gems/linked-list-0.0.13 ~/rpmbuild/BUILD/linked-list-0.0.13/usr/share/gems/gems/linked-list-0.0.13 ~/rpmbuild/BUILD/linked-list-0.0.13 + sed -i '/bundler/ s/^/#/' Rakefile + ruby -Ilib:test -e 'Dir.glob "test/**/*_test.rb",&method(:require)' Traceback (most recent call last): 3: from -e:1:in `<main>' 2: from -e:1:in `glob' 1: from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require' /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- test/conversions_test.rb (LoadError) error: Bad exit status from /var/tmp/rpm-tmp.OrwEM1 (%check)
Spec file and srpm have been updated, tests are working now. + pushd ./usr/share/gems/gems/linked-list-0.0.13 ~/rpmbuild/BUILD/linked-list-0.0.13/usr/share/gems/gems/linked-list-0.0.13 ~/rpmbuild/BUILD/linked-list-0.0.13 + sed -i '/bundler/ s/^/#/' Rakefile + ruby -Ilib:test -r test_helper.rb -e 'Dir.glob "./test/*_test.rb", &method(:require)' Run options: --seed 59628 # Running: .................................................................................................................. Fabulous run in 0.021618s, 5273.2808 runs/s, 7169.8117 assertions/s. 114 runs, 155 assertions, 0 failures, 0 errors, 0 skips + popd
Is the `sed -i '/bundler/ s/^/#/' Rakefile` required? Are you using the Rakefile anywhere?
> The `-r test_helper.rb` should not be necessary. Just adding `test` into load path via the `-I` option should be enough. You are right, Vit. The `test_helper.rb` is required from all the "*_test.rb" file. ``` $ grep -r test_helper test/ test/list_test.rb:require 'test_helper' test/node_test.rb:require 'test_helper' test/conversions_test.rb:require 'test_helper' ``` Leigh, could you try without `-r test_helper.rb` option? Then you can remove the option.
Thanks for the help, spec file and srpm updated. (In reply to Vít Ondruch from comment #7) > Is the `sed -i '/bundler/ s/^/#/' Rakefile` required? Are you using the > Rakefile anywhere? I don't believe so, line removed (In reply to Jun Aruga from comment #8) > > The `-r test_helper.rb` should not be necessary. Just adding `test` into load path via the `-I` option should be enough. > > You are right, Vit. The `test_helper.rb` is required from all the > "*_test.rb" file. > > ``` > $ grep -r test_helper test/ > test/list_test.rb:require 'test_helper' > test/node_test.rb:require 'test_helper' > test/conversions_test.rb:require 'test_helper' > ``` > > Leigh, could you try without `-r test_helper.rb` option? Then you can remove > the option. It works ok without `-r test_helper.rb`
> %exclude %{gem_instdir}/.gitignore > %exclude %{gem_instdir}/.travis.yml Following way could be more maintainable. You see it in other rubygem-*.spec files. You can replace the 2 lines to `%exclude %{gem_instdir}/.*`. ``` -%exclude %{gem_instdir}/.gitignore -%exclude %{gem_instdir}/.travis.yml +%exclude %{gem_instdir}/.* `` I executed `fedora-review` command for this ticket. $ fedora-review -b 1779403 Then seeing `1779403-rubygem-linked-list/review.txt`. > rpmlint okay. ``` rubygem-linked-list.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. ``` * License check: ok * Installing built binary RPMs in mock environment: ok ``` $ mock -i rubygem-linked-list-0.0.13-1.fc32.noarch.rpm rubygem-linked-list-doc-0.0.13-1.fc32.noarch.rpm ``` * Running the installed RPM in mock environment: ok ``` $ mock shell <mock-chroot> sh-5.0# gem list | grep linked-list linked-list (0.0.13) <mock-chroot> sh-5.0# irb irb(main):001:0> require 'linked-list' => true ``` * Scratch build: ok ``` $ koji build --scratch --nowait rawhide rubygem-linked-list-0.0.13-1.fc31.src.rpm https://koji.fedoraproject.org/koji/taskinfo?taskID=39429931 ``` Package is APPROVED. Please fix the `%exclude %{gem_instdir}/.*` issue above when importing.
Leigh, you next action could be possibly https://fedoraproject.org/wiki/Package_Review_Process > If you have not yet been sponsored ... or > When your package pass the review, you should use the fedpkg tool to request a git repository for it.
(In reply to Jun Aruga from comment #11) > Leigh, you next action could be possibly > > https://fedoraproject.org/wiki/Package_Review_Process > > > If you have not yet been sponsored ... > > or > > > When your package pass the review, you should use the fedpkg tool to request a git repository for it. Thank you for reviewing, SCM request is done.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-linked-list
Package built for f32, removing block. https://koji.fedoraproject.org/koji/buildinfo?buildID=1419651
FEDORA-2019-0ae6be7263 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-0ae6be7263
FEDORA-2019-f7876a8b0a has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-f7876a8b0a
rubygem-linked-list-0.0.13-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-f7876a8b0a
rubygem-linked-list-0.0.13-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-0ae6be7263
rubygem-linked-list-0.0.13-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-linked-list-0.0.13-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.