Bug 1779425 - gnome-shell-extension-openweather does not load
Summary: gnome-shell-extension-openweather does not load
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-shell-extension-openweather
Version: 31
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Artem
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-12-03 23:56 UTC by Michal Jaegermann
Modified: 2020-02-02 01:34 UTC (History)
2 users (show)

Fixed In Version: gnome-shell-extension-openweather-1-0.39.20200110gitd9fb790.fc31 gnome-shell-extension-openweather-1-0.41.20200124git1c9dd03.fc31
Clone Of:
Environment:
Last Closed: 2020-02-02 01:34:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
suggested possible patch for the issue (3.56 KB, patch)
2019-12-15 18:34 UTC, Michal Jaegermann
no flags Details | Diff

Description Michal Jaegermann 2019-12-03 23:56:25 UTC
Description of problem:

After recent updates gnome-shell-extension-openweather does not load.  At least not always. The following shows up in logs:

gnome-shell[1455]: Usage of object.actor is deprecated for OpenweatherMenuButton
     get@resource:///org/gnome/shell/ui/environment.js:249:29
     _init@/usr/share/gnome-shell/extensions/openweather-extension/exte>
     wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
     enable@/usr/share/gnome-shell/extensions/openweather-extension/ext>
     _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:131:13
     _enableAllExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:486:17
     _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:485:13
     _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:513:13
     _emit@resource:///org/gnome/gjs/modules/signals.js:135:27
     _sync@resource:///org/gnome/shell/ui/sessionMode.js:205:9
     popMode@resource:///org/gnome/shell/ui/sessionMode.js:174:9
     _continueDeactivate@resource:///org/gnome/shell/ui/screenShield.js:1200:13
     deactivate@resource:///org/gnome/shell/ui/screenShield.js:1188:13
     _liftShield@resource:///org/gnome/shell/ui/screenShield.js:621:13
     _onLockScreenKeyPress@resource:///org/gnome/shell/ui/screenShield.js:681:9

and the extension may end deactivated.

Version-Release number of selected component (if applicable):
gnome-shell-extension-openweather-1-0.38.20181119git7ea4ce7.fc31

Additional information:

"Usage" deprecation message from gnome-shell and the timing suggest that the issue is triggered by an update to gnome-shell-3.34.1-4.fc31.  Moreover the problem seems to be intermittent as after a reboot the extension may or may not load even if a logged complaint remains the same in both cases.

Comment 1 Artem 2019-12-04 07:41:50 UTC
This is bad news. The problem is that gnome-shell-extension-openweather no more actively developed. Did you tried to report this into upstream?

https://gitlab.com/jenslody/gnome-shell-extension-openweather/issues

Comment 3 Michal Jaegermann 2019-12-04 17:06:45 UTC
(In reply to Artem from comment #1)
> This is bad news. The problem is that gnome-shell-extension-openweather no
> more actively developed.

I am afraid that I am quite clueless about JS but I would imagine that for somebody familiar with the language making adjustments to changes described, say, here: https://blogs.gnome.org/shell-dev/2019/11/22/a-review-of-gnome-shell-mutter-3-34/ should not be that hard.  The quoted reference in particular boasts about "JS60 migration".

Comment 4 Michal Jaegermann 2019-12-15 18:34:24 UTC
Created attachment 1645355 [details]
suggested possible patch for the issue

If you try to search on the web for "Usage of object.actor is deprecated" in gjs that seems to be a quite popular issue.  On occasions one can even find fixes for particular instances although I was not lucky enough to stumble upon an explanation.  For example you can look at this: https://github.com/ubuntu/gnome-shell-extension-appindicator/issues/186.  Following "monkey see, monkey do" principle I made up the attached patch for gnome-shell-extension-openweather.  So far it does not appear to adversly affect an operation of this extension and deprecation warnings are no longer there.  Still it will be a good idea if somebody who knows what they are doing look at the proposed fix.

Comment 5 Fedora Update System 2020-01-11 01:25:09 UTC
gnome-shell-extension-openweather-1-0.39.20200110gitd9fb790.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-fceb30bb86

Comment 6 Michal Jaegermann 2020-01-11 02:46:25 UTC
(In reply to Fedora Update System from comment #5)
> gnome-shell-extension-openweather-1-0.39.20200110gitd9fb790.fc31 has been
> pushed to the Fedora 31 testing repository.

I see that just today Jens Lody added a few commits past d9fb790 which look like that may be significant with respect to compatibility with newer versions of gnome-shell. :-)

Comment 7 Jens Lody 2020-01-11 11:49:21 UTC
(In reply to Michal Jaegermann from comment #6)
> (In reply to Fedora Update System from comment #5)
> > gnome-shell-extension-openweather-1-0.39.20200110gitd9fb790.fc31 has been
> > pushed to the Fedora 31 testing repository.
> 
> I see that just today Jens Lody added a few commits past d9fb790 which look
> like that may be significant with respect to compatibility with newer
> versions of gnome-shell. :-)

It should now work with gnome-shell 3.35 also (tested in my Rawhide vm).
One persisting (and really annoying) issue, is the much too small result list after searching a location.
I did not find a proper solution.
For the moment I might set fixed values for height and width, even if it is pretty ugly, but at least the user can see the search result.

Comment 8 Jens Lody 2020-01-11 12:06:03 UTC
Just pushed a workaround for the searchlist issue.
So all main bugs should be fixed.

Comment 9 Fedora Update System 2020-01-20 01:43:29 UTC
gnome-shell-extension-openweather-1-0.39.20200110gitd9fb790.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Michal Jaegermann 2020-01-23 23:52:38 UTC
(In reply to Fedora Update System from comment #9)
> gnome-shell-extension-openweather-1-0.39.20200110gitd9fb790.fc31 has been
> pushed to the Fedora 31 stable repository. If problems still persist, please
> make note of it in this bug report.

This is not the original problem but gnome-shell-extension-openweather-1-0.39.20200110gitd9fb790.fc31 apparently aquired a habit of flooding logs with messages like that:

gnome-shell[1839]: Object St.Icon (0x5572cf897120), has been already deallocated — impossible to set any property on it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
gnome-shell[1839]: Object St.Label (0x5572ceea0af0), has been already deallocated — impossible to set any property on it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
gnome-shell[1839]: #4   5572cdb238f0 i   self-hosted:979 (7f8af1f2f940 @ 440)
gnome-shell[1839]: #3   5572cdb239b0 i   /usr/share/gnome-shell/extensions/openweather-extension/extension.js:1226 (7f8af0d5eee0 @ 112)
gnome-shell[1839]: #2   5572cdb23a48 i   /usr/share/gnome-shell/extensions/openweather-extension/openweathermap_org.js:413 (7f8af0d64160 @ 107)
gnome-shell[1839]: #1   5572cdb23ad0 i   /usr/share/gnome-shell/extensions/openweather-extension/openweathermap_org.js:387 (7f8af0d64040 @ 1735)
gnome-shell[1839]: #0   5572cdb23be8 i   /usr/share/gnome-shell/extensions/openweather-extension/openweathermap_org.js:486 (7f8af0d641f0 @ 1097)
gnome-shell[1839]: == Stack trace for context 0x5572ccff2380 ==

Once this starts it appears to be quite relentless.  Recently I logged some 8 thousand plus lines of that kind repeated over and over.

In the meantime git repo for gnome-shell-extension-openweather was updated by the author to commit 1c9dd03b360c6b161e3ae89c351af88ab0f183d2.  I am running now this version and so far no complaints (although I cannot be really sure that these messages will not reappear; it took some time before quoted log entries started to show up).

Comment 11 Fedora Update System 2020-01-24 01:42:37 UTC
FEDORA-2020-f512899731 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f512899731

Comment 12 Fedora Update System 2020-01-25 08:18:49 UTC
gnome-shell-extension-openweather-1-0.41.20200124git1c9dd03.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f512899731

Comment 13 Michal Jaegermann 2020-02-01 17:17:30 UTC
(In reply to Fedora Update System from comment #12)
> gnome-shell-extension-openweather-1-0.41.20200124git1c9dd03.fc31 has been
> pushed to the Fedora 31 testing repository.

Just for the record.  After a week or so running git1c9dd03 version without any incidents I was hit by a series of complaints like in comment #10.  Here is a sample:


Jan 30 22:47:08 gnome-shell[1416]: Object St.BoxLayout (0x5616cde89470), has been already deallocated — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Jan 30 22:47:08 gnome-shell[1416]: == Stack trace for context 0x5616cccc7310 ==
Jan 30 22:47:08 gnome-shell[1416]: #0   5616cdb6cb58 i   resource:///org/gnome/shell/ui/popupMenu.js:737 (7f2700622040 @ 22)
Jan 30 22:47:08 gnome-shell[1416]: #1   5616cdb6cab8 i   resource:///org/gnome/shell/ui/popupMenu.js:755 (7f2700622310 @ 23)
Jan 30 22:47:08 gnome-shell[1416]: #2   5616cdb6ca00 i   /usr/share/gnome-shell/extensions/openweather-extension/extension.js:900 (7f26eb25c0d0 @ 37)
Jan 30 22:47:08 gnome-shell[1416]: #3   5616cdb6c978 i   /usr/share/gnome-shell/extensions/openweather-extension/openweathermap_org.js:411 (7f26eb25ef70 @ 92)
Jan 30 22:47:08 gnome-shell[1416]: #4   5616cdb6c8e0 i   /usr/share/gnome-shell/extensions/openweather-extension/extension.js:1125 (7f26eb25cd30 @ 112)
Jan 30 22:47:08 gnome-shell[1416]: #5   5616cdb6c820 i   self-hosted:979 (7f270042f940 @ 440)
Jan 30 22:47:08 gnome-shell[1416]: clutter_container_get_children: assertion 'CLUTTER_IS_CONTAINER (container)' failed
Jan 30 22:47:08 gnome-shell[1416]: Object St.BoxLayout (0x5616cde89470), has been already deallocated — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Jan 30 22:47:08 gnome-shell[1416]: == Stack trace for context 0x5616cccc7310 ==
......................
Feb 01 09:17:07 gnome-shell[1416]: #4   5616d0df3e50 i   self-hosted:979 (7f270042f940 @ 440)
Feb 01 09:17:07 gnome-shell[1416]: == Stack trace for context 0x5616cccc7310 ==
Feb 01 09:17:07 gnome-shell[1416]: #0   5616d0df4148 i   /usr/share/gnome-shell/extensions/openweather-extension/openweathermap_org.js:486 (7f26eb263040 @ 1097)
Feb 01 09:17:07 gnome-shell[1416]: #1   5616d0df4030 i   /usr/share/gnome-shell/extensions/openweather-extension/openweathermap_org.js:387 (7f26eb25ee50 @ 1735)
Feb 01 09:17:07 gnome-shell[1416]: #2   5616d0df3fa8 i   /usr/share/gnome-shell/extensions/openweather-extension/openweathermap_org.js:413 (7f26eb25ef70 @ 107)
Feb 01 09:17:07 gnome-shell[1416]: #3   5616d0df3f10 i   /usr/share/gnome-shell/extensions/openweather-extension/extension.js:1125 (7f26eb25cd30 @ 112)
Feb 01 09:17:07 gnome-shell[1416]: #4   5616d0df3e50 i   self-hosted:979 (7f270042f940 @ 440)
Feb 01 09:17:07 gnome-shell[1416]: Object St.Label (0x5616d0a22f80), has been already deallocated — impossible to set any property on it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Feb 01 09:17:07 gnome-shell[1416]: Object St.Icon (0x5616d04a44b0), has been already deallocated — impossible to set any property on it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Feb 01 09:17:07 gnome-shell[1416]: Object St.Label (0x5616d0a9fc80), has been already deallocated — impossible to set any property on it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Feb 01 09:17:07 gnome-shell[1416]: Object St.Label (0x5616d08d8e50), has been already deallocated — impossible to set any property on it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Feb 01 09:17:07 gnome-shell[1416]: == Stack trace for context 0x5616cccc7310 ==
.....................

I do not see any obvious reasons neither why this flood started nor why it stopped. So far for about an hour these complaints did not reappear.

Comment 14 Fedora Update System 2020-02-02 01:34:40 UTC
gnome-shell-extension-openweather-1-0.41.20200124git1c9dd03.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.