Bug 1779588

Created attachment 1643446 [details]
/var/log of rhvh

The placeholder for "redhat-virtualization-host-4.4.0-20191107.1.el8_1" is "redhat-virtualization-host-image-update-placeholder-4.4.0-8.el8ev.noarch"
The placeholder for "redhat-virtualization-host-4.4.0-20191201.0.el8_1.noarch.rpm" is "redhat-virtualization-host-image-update-placeholder-4.4.0-9.el8ev.noarch"

The version of placeholder is different, should the upgrade package be detected and open this bug?

(In reply to peyu from comment #3)
> The placeholder for "redhat-virtualization-host-4.4.0-20191107.1.el8_1" is
> "redhat-virtualization-host-image-update-placeholder-4.4.0-8.el8ev.noarch"
> The placeholder for
> "redhat-virtualization-host-4.4.0-20191201.0.el8_1.noarch.rpm" is
> "redhat-virtualization-host-image-update-placeholder-4.4.0-9.el8ev.noarch"
> 
> The version of placeholder is different, should the upgrade package be
> detected and open this bug?

In this case, yes, the version should be detected

Pengshan, what happens if you do a normal "dnf update" on the host ?

(In reply to Yuval Turgeman from comment #5)
> Pengshan, what happens if you do a normal "dnf update" on the host ?

Using normal "dnf update" can upgrade to new version. please refer to https://bugzilla.redhat.com/show_bug.cgi?id=1770683#c9

Can you also attach engine.log from the engine?

Created attachment 1645989 [details]
engine logs: /var/log/ovirt-engine

peyu, I can't reproduce this, can you share the output for `rpm -qa` before trying to upgrade in the UI ?

Ok forget my last comment, I managed to reproduce.  It looks like the output from the ovirt-host-upgrade.yml playbook is not complete for the engine.  It seems to be looking for a "changes" key:

https://github.com/oVirt/ovirt-engine/blob/2685a0421443ebde164f534a98d34385ba7f6427/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleRunnerHTTPClient.java#L272

While the output for the playbook looks like this:

changed: [192.168.122.178] => {
    "changed": true, 
    "invocation": {
        "module_args": {
            "allow_downgrade": false, 
            "autoremove": false, 
            "bugfix": false, 
            "conf_file": null, 
            "disable_excludes": null, 
            "disable_gpg_check": false, 
            "disable_plugin": [], 
            "disablerepo": [], 
            "download_dir": null, 
            "download_only": false, 
            "enable_plugin": [], 
            "enablerepo": [], 
            "exclude": [], 
            "install_repoquery": true, 
            "install_weak_deps": true, 
            "installroot": "/", 
            "list": null, 
            "lock_timeout": 30, 
            "name": [
                "*"
            ], 
            "releasever": null, 
            "security": false, 
            "skip_broken": false, 
            "state": "latest", 
            "update_cache": true, 
            "update_only": false, 
            "validate_certs": true
        }
    }, 
    "msg": "Check mode: No changes made, but would have if not in check mode", 
    "rc": 0, 
    "results": []
}

Any idea, Ondra ?

Moving this to ovirt-engine, we should either rely only on "changed" without specifying the available packages for update, or add a call to dnf check-update

Martin can you prioritize this one?

Can you reproduce this issue with the latest RHVH and engine build?

I tested this issue and still cannot detect the upgrade package through RHVM.

Version-Release number of selected component (if applicable):
1）RHVM Software Version: 4.4.0-0.20.master.el7
2）RHVH:
  redhat-virtualization-host-4.4.0-20200212.0.el8_2
  redhat-virtualization-host-4.4.0-20200226.0.el8_2 


Test steps:
1. Install redhat-virtualization-host-4.4.0-20200212.0.el8_2 and reboot
2. Add RHVH to RHVM
3. Login to RHVH, set local repo and point to redhat-virtualization-host-4.4.0-20200226.0.el8_2
4. Login to RHVM, from "Compute >> Hosts" page, select the host and click "Installation -> Check for Upgrade" 

Test results:
1. No new packages found to upgrade. The logs are as follows: 
Check for available updates on host peyu-0228-01 was completed successfully with message 'no updates found.'.


I will test again when new engine is released.

I tested this bug with the latest engine 4.4.0-0.24.master.el8ev and it still cannot detect the upgrade package.

Test version:
1）RHVM: 4.4.0-0.24.master.el8ev
2）RHVH:
  redhat-virtualization-host-4.4.0-20200212.0.el8_2
  redhat-virtualization-host-4.4.0-20200226.0.el8_2

I tested this bug with the latest engine 4.4.0-0.26.master.el8ev, it can detect the RHVH upgrade package from RHVH UI.

Test version:
RHVM: 4.4.0-0.26.master.el8ev

Test steps:
1. Install redhat-virtualization-host-4.4.0-20200212.0.el8_2
2. Add RHVH to RHVM
3. Login to RHVH, set local repo and point to "redhat-virtualization-host-4.4.0-20200318.0.el8_2.noarch.rpm"
4. Login to RHVM, from "Compute -> Hosts" page, select the host and click "Installation -> Check for Upgrade" 

Test results:
1. Check for available updates on host peyu-0323-upgrade was completed successfully with message 'found updates for packages redhat-virtualization-host-image-update.noarch'.

So I will move bug status to VERIFIED

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (RHV Host (redhat-virtualization-host) 4.4), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:3316