Bug 1780701 - Reposurgeon fails during certain operations with Python errors due to formatting
Summary: Reposurgeon fails during certain operations with Python errors due to formatting
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: reposurgeon
Version: 31
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Denis Fateyev
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-12-06 16:48 UTC by jadecristal
Modified: 2020-06-29 02:00 UTC (History)
3 users (show)

Fixed In Version: reposurgeon-3.47-3.fc31 reposurgeon-3.47-3.fc32
Clone Of:
Environment:
Last Closed: 2020-06-29 01:05:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
fix tab space issue (6.22 KB, patch)
2020-05-25 06:41 UTC, Maya Rashish
no flags Details | Diff

Description jadecristal 2019-12-06 16:48:51 UTC
Description of problem:

Reposurgeon fails during certain operations with Python errors due to formatting. This occurs in multiple operations.

Version-Release number of selected component (if applicable):
3.47 1.fc31 from reposurgeon-3.47-1.fc31 @System

How reproducible:
Completely

Steps to Reproduce:
1. Assuming the package is installed, create a directory and run repotool initialize PROJECTNAME, e.g.:

repotool initialize sampleconversion

Respond with "svn" and "git" to the two questions on the to/from systems.

2. Edit the Makefile generated by repotool and add a valid Subversion https repository.

3. In the project directory, run "make stubmap" (which would read the committers from the repo to produce a committer-to-email mapping file of PROJECTNAME.map)
OR
run simply "make"

Actual results:

------------------------------------------------------------
reposurgeon "verbose 1" 'script repos3.opts' "read  <repos3.svn" 'authors read <repos3.map' 'sourcetype svn' 'prefer git' 'script repos3.lift' 'legacy write >repos3.fo' 'write >repos3.fi'
  File "/usr/bin/reposurgeon", line 5043
    announce(DEBUG_TOPOLOGY, "r%s: file copy matching %s finds %s" \
                                                                   ^
TabError: inconsistent use of tabs and spaces in indentation
make: *** [Makefile:63: repos3.fi] Error 1
------------------------------------------------------------
(cd repos3-mirror/ >/dev/null; repotool export) >repos3.svn
reposurgeon "verbose 1" 'script repos3.opts' "read  <repos3.svn" 'authors read <repos3.map' 'sourcetype svn' 'prefer git' 'script repos3.lift' 'legacy write >repos3.fo' 'write >repos3.fi'
  File "/usr/bin/reposurgeon", line 5121
    announce(DEBUG_EXTRACT, "no branch analysis")
                                                ^
TabError: inconsistent use of tabs and spaces in indentation
make: *** [Makefile:63: repos3.fi] Error 1
------------------------------------------------------------

Expected results:
No errors.

Additional info:
Multiple different statements and errors have occurred; attempting to correct them by modifying formatting in the /usr/bin/reposurgeon file seems to incrementally make them go away if parts of the file are reformatted add/remove tabs/spaces.

There exists a newer (3.48) version from the author's website; however, I don't know how the packaging of this component works.
This is the final version of the product based on python; 4.0 will be written using Go, according to the author's website.

Comment 1 Maya Rashish 2020-05-25 06:41:02 UTC
Created attachment 1691695 [details]
fix tab space issue

patch for the package

Comment 2 Denis Fateyev 2020-06-19 18:22:28 UTC
Pushed updates for F31, F32 and Rawhide.
Reposurgeon 4.x will be pushed once appropriate Go dependencies modules PRs are passed.

Comment 3 Fedora Update System 2020-06-19 18:22:56 UTC
FEDORA-2020-4d509ff0d2 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-4d509ff0d2

Comment 4 Fedora Update System 2020-06-19 18:22:56 UTC
FEDORA-2020-b04a209d5e has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b04a209d5e

Comment 5 Fedora Update System 2020-06-21 17:20:14 UTC
FEDORA-2020-b04a209d5e has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-b04a209d5e`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b04a209d5e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2020-06-21 17:20:29 UTC
FEDORA-2020-4d509ff0d2 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-4d509ff0d2`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-4d509ff0d2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2020-06-29 01:05:40 UTC
FEDORA-2020-b04a209d5e has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2020-06-29 02:00:01 UTC
FEDORA-2020-4d509ff0d2 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.