Spec URL: https://sagitter.fedorapeople.org/mmtf-cpp/mmtf-cpp.spec SRPM URL: https://sagitter.fedorapeople.org/mmtf-cpp/mmtf-cpp-1.0.0-1.fc31.src.rpm Description: Libraries used by latest release of PyMOL Fedora Account System Username: sagitter
The devel package must provide %{name}-static: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packagin
Spec URL: https://sagitter.fedorapeople.org/mmtf-cpp/mmtf-cpp.spec SRPM URL: https://sagitter.fedorapeople.org/mmtf-cpp/mmtf-cpp-1.0.0-2.fc31.src.rpm Add Provides for virtual static libraries.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "*No copyright* Expat License". 19 files have unknown license. Detailed output of licensecheck in /home/sergio/fedora-scm/1780848-mmtf- cpp/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mmtf- cpp-devel [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mmtf-cpp-devel-1.0.0-2.fc32.x86_64.rpm mmtf-cpp-doc-1.0.0-2.fc32.noarch.rpm mmtf-cpp-1.0.0-2.fc32.src.rpm mmtf-cpp.src: W: spelling-error %description -l en_US biomolecular -> bio molecular, bio-molecular, molecularity mmtf-cpp.src: E: description-line-too-long C The Macromolecular Transmission Format (MMTF) is a new compact binary format to transmit and 3 packages and 0 specfiles checked; 1 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). mmtf-cpp-devel.x86_64: W: invalid-url URL: https://github.com/rcsb/mmtf-cpp <urlopen error [Errno -2] Name or service not known> mmtf-cpp-doc.noarch: W: invalid-url URL: https://github.com/rcsb/mmtf-cpp <urlopen error [Errno -2] Name or service not known> 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://github.com/rcsb/mmtf-cpp/archive/v1.0.0/mmtf-cpp-1.0.0.tar.gz : CHECKSUM(SHA256) this package : 881f69c4bb56605fa63fd5ca50842facc4947f686cbf678ad04930674d714f40 CHECKSUM(SHA256) upstream package : 881f69c4bb56605fa63fd5ca50842facc4947f686cbf678ad04930674d714f40 Requires -------- mmtf-cpp-devel (rpmlib, GLIBC filtered): msgpack-devel(x86-64) mmtf-cpp-doc (rpmlib, GLIBC filtered): Provides -------- mmtf-cpp-devel: mmtf-cpp-devel mmtf-cpp-devel(x86-64) mmtf-cpp-static mmtf-cpp-doc: mmtf-cpp-doc Generated by fedora-review 0.7.4 (54fa030) last change: 2019-12-07 Command line :/usr/bin/fedora-review -b 1780848 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Ruby, PHP, Python, R, Haskell, Ocaml, SugarActivity, Java, Perl, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Package APPROVED , package review and rpmlint just notice this thing [1] that can be improved but is just a very small detail. Do we have to disable debug symbols [2] ? [1] mmtf-cpp.src: E: description-line-too-long C The Macromolecular Transmission Format (MMTF) is a new compact binary format to transmit and [2] %global debug_package %{nil}
You have posted a fedora review template with empty checkboxes. Was that your intention? > Do we have to disable debug symbols? Yes, there is no compiled content shipped. This is a header only library. Would normally be noarch, but guidelines say it shall be arched.
(In reply to Miro Hrončok from comment #4) > You have posted a fedora review template with empty checkboxes. Was that > your intention? I just copied all output , is wrong ? > > Do we have to disable debug symbols? > > Yes, there is no compiled content shipped. This is a header only library. > Would normally be noarch, but guidelines say it shall be arched. OK , so it is correct .
(In reply to Sergio Monteiro Basto from comment #5) > (In reply to Miro Hrončok from comment #4) > > You have posted a fedora review template with empty checkboxes. Was that > > your intention? > > I just copied all output , is wrong ? Yes. As a reviewer you are supposed to fill in the blanks. fedora review is not fully automated, only semi automated. See the warning above the stuff you copied.
Sergio, complete the review, please.
All seems fine . Package APPROVED
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mmtf-cpp