Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1781439

Summary:	Update from z3 to z9 doesn't install tmpwatch package and it causes the failure of logrotate to container logs.
Product:	Red Hat OpenStack	Reporter:	Keigo Noha <knoha>
Component:	openstack-tripleo-heat-templates	Assignee:	Cédric Jeanneret <cjeanner>
Status:	CLOSED ERRATA	QA Contact:	Sasha Smolyak <ssmolyak>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	13.0 (Queens)	CC:	cjeanner, mburns
Target Milestone:	---	Keywords:	Triaged, ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-tripleo-heat-templates-8.4.1-28.el7ost	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-10 11:23:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Keigo Noha 2019-12-10 02:50:03 UTC

Description of problem:
Update from z3 to z9 doesn't install tmpwatch package and it causes the failure of logrotate to container logs.

The current RHOSP13 T-H-T doesn't include the update_task that installs tmpwatch package.
The new overcloud image includes tmpwatch in it. However, z3 or earlier images didn't contain the package.
It means that T-H-T should have the task in update procedure.

Version-Release number of selected component (if applicable):
The latest RHOSP13 T-H-T

How reproducible:
Always

Steps to Reproduce:
1. Update overcloud node.
2. Check whether following error exists.
~~~
container-tmpwatch:/etc/cron.daily/containers-tmpwatch: line 2: tmpwatch: command not found
~~~
3.

Actual results:
tmpwatch is not installed.

Expected results:
tmpwatch is installed.

Additional info:

Comment 1 Cédric Jeanneret 2019-12-10 12:19:51 UTC

Hello Keigo,

That's weird: the deploy steps are re-played after an update, meaning we should get the tmpwatch package installed.
Since the cron job is in the "daily" directory, it might be launched at any time - even before the package is actually installed.

Care to check if tmpwatch RPM is present on the system at the end of the update? As a proof that the deploy steps are played, the presence of that cron job: it's created during the deploy_steps_tasks, not some update_tasks block..

Cheers,

C.

Comment 2 Cédric Jeanneret 2019-12-10 12:58:22 UTC

Just found out the issue: the tmpwatch install part is not included for the overcloud... The added patch corrects this for master and will be backported - but we probably need a specific patch for old releases since there's a huge tree change around rocky (or stein - anyway).

Lemme check that, I should be able to propose another patch for those out-of-tree releases.

Cheers,

C.

Comment 3 Cédric Jeanneret 2019-12-10 13:00:07 UTC

yay. Can't add the link in "links".. https://review.opendev.org/698232

Comment 4 Cédric Jeanneret 2019-12-10 13:28:07 UTC

And rocky + older versions: https://review.opendev.org/698238

Comment 5 Cédric Jeanneret 2019-12-19 12:21:29 UTC

Hello there,

So Upstream Queens is merged, we're just waiting for Train and Stein to get something merged.

I'll already start the downstream backports for OSP-13 + OSP-14 (Queens and Rocky), and check if I can easily do some more downstream work for OSP-15 (Stein) since it's needed for that one as well. OSP-16 should be covered as soon as we get the upstream merged, iirc - I'll keep an eye on it anyway.

ETA for packages is probably next year though. I'll need to clone this bug for each OSP version.

Cheers,

C.

Comment 6 Keigo Noha 2019-12-20 00:28:52 UTC

Hi Cedric,

Thank you for your quick work.
The customer installed tmpwatch manually. So, there is no urgent issue.
They request us to fix this issue in the next z release.

Best Regards,
Keigo Noha

Comment 9 errata-xmlrpc 2020-03-10 11:23:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0760