Spec URL: https://people.redhat.com/nhorman/python-npyscreen.spec SRPM URL: https://people.redhat.com/nhorman/python-npyscreen-0-20191210git8ce31204e.fc30.src.rpm Description: Python library to create forms using python ncurses Fedora Account System Username: nhorman
- Use Pypi (pyp2rpm -b3 npyscreen) to get a valid release number: # Created by pyp2rpm-3.3.2 %global pypi_name npyscreen Name: python-%{pypi_name} Version: 4.10.5 Release: 1%{?dist} Summary: Writing user interfaces without all that ugly mucking about in hyperspace License: BSD URL: http://www.npcole.com/npyscreen/ Source0: %{pypi_source} BuildArch: noarch BuildRequires: python3-devel BuildRequires: python3dist(setuptools) %description This library provides a framework for developing console applications using Python and curses.This framework should be powerful enough to create everything from quick, simple programs to complex, multi-screen applications. It is designed to make doing the simple tasks very quick and to take much of the pain out of writing larger applications. %package -n python3-%{pypi_name} Summary: %{summary} %{?python_provide:%python_provide python3-%{pypi_name}} %description -n python3-%{pypi_name} This library provides a framework for developing console applications using Python and curses.This framework should be powerful enough to create everything from quick, simple programs to complex, multi-screen applications. It is designed to make doing the simple tasks very quick and to take much of the pain out of writing larger applications. %prep %autosetup -n %{pypi_name}-%{version} for i in $(find . -name '*.py') do sed -i -e"s/#\!\/usr\/bin\/python//" $i sed -i -e"s/#\!\/usr\/bin\/env python//" $i sed -i -e"s/#\!\/usr\/bin\/env pyton//" $i done %build %py3_build %install %py3_install %files -n python3-%{pypi_name} %{python3_sitelib}/%{pypi_name} %{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info %changelog * Tue Dec 10 2019 Neil Horman <nhorman> - 4.10.5-1 - Initial release in Fedora
Spec URL: https://people.redhat.com/nhorman/python-npyscreen.spec SRPM URL: https://people.redhat.com/nhorman/python-npyscreen-4.10.5-1.fc30.src.rpm updated with requested corrections
Source0: https://files.pythonhosted.org/packages/source/n/%{pypi_name}/%{pypi_name}-%{version}.tar.gz → Source0: %{pypi_source} Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-clause "Simplified" License". 93 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-npyscreen/review-python- npyscreen/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-npyscreen-4.10.5-1.fc32.noarch.rpm python-npyscreen-4.10.5-1.fc32.src.rpm python3-npyscreen.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
a few quick notes: - %license missing - use %pypi_source instead of manually building the URL - Missing spaces in decription ("curses.This", "applications.There") - also you might want to shorten the description a bit (imho only) - "%{pypi_name}-%{version}-py?.?.egg-info" -> this will break when there is a Python 3.10 - you can use "%{pypi_name}-%{version}-py%{python3_version}.egg-info" I noticed that the last release was 4 years ago and there is no public source control. Do really want to package this library? Seems to be dead upstream (so a Python 3.9 transition is on you).
Even though Robert-André approved the package please fix the missing %license file. (This is required as per Fedora packaging policy!)
Sorry I missed it.
Weird that fedora-revuuew didn't warn me on the missing LICENSE. Please add it to the files section. Cut down the descriptions too: %description This library provides a framework for developing console applications using Python and curses. This framework should be powerful enough to create everything from quick, simple programs to complex, multi-screen applications. It is designed to make doing the simple tasks very quick and to take much of the pain out of writing larger applications. %package -n python3-%{pypi_name} Summary: %{summary} %{?python_provide:%python_provide python3-%{pypi_name}} %description -n python3-%{pypi_name} This library provides a framework for developing console applications using Python and curses. This framework should be powerful enough to create everything from quick, simple programs to complex, multi-screen applications. It is designed to make doing the simple tasks very quick and to take much of the pain out of writing larger applications.
yes, I'll take care of that prior to importing the package, thanks!
Also, yes, in regards to the upstream maintenence, the project moved to github, and is actively maintained there
fixed requested items locally, will import that version soon
ah, you didn't hit the + on review, heres the new spec file and srpm for you to review: Spec URL: https://people.redhat.com/nhorman/python-npyscreen.spec SRPM URL: https://people.redhat.com/nhorman/python-npyscreen-4.10.5-2.fc30.src.rpm
No: URL: %pypi_source Source0: https://files.pythonhosted.org/packages/source/n/%{pypi_name}/%{pypi_name}-%{version}.tar.gz %pypi_source go in Source0: URL: http://www.npcole.com/npyscreen/ Source0: %{pypi_source} Package approved. but please fix this before import.
will do
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-npyscreen